Skip to content

fix(workflow-executor): align @forestadmin/* deps with the workspace - #1643

Merged
hercemer42 merged 3 commits into
mainfrom
fix/workflow-executor-align-dep-versions
Jun 10, 2026
Merged

fix(workflow-executor): align @forestadmin/* deps with the workspace#1643
hercemer42 merged 3 commits into
mainfrom
fix/workflow-executor-align-dep-versions

Conversation

@hercemer42

@hercemer42 hercemer42 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

@forestadmin/workflow-executor:build is currently failing in CI (and on main) with a wall of TS2305/TS2339/TS2614 errors:

'@forestadmin/ai-proxy' has no exported member 'AiClient' / 'BaseChatModel' / 'BaseMessage' / 'DynamicStructuredTool' / …
'@forestadmin/forestadmin-client' has no exported member 'ServerUtils'
Property 'getOne' does not exist on type 'Collection'   (@forestadmin/agent-client)

Root cause: workflow-executor pins its @forestadmin/* deps to stale exact versions that lag the workspace and don't export the APIs its source uses. Every other package in the monorepo references the current workspace versions and builds fine — workflow-executor is the lone laggard. (It's a chicken-and-egg: semantic-release bumps these on release, but the broken build blocks the release that would fix them.)

Change

Bump the three pinned deps to the current workspace versions:

dep from to
@forestadmin/agent-client 1.5.10 1.6.0
@forestadmin/ai-proxy 1.10.1 1.11.0
@forestadmin/forestadmin-client 1.39.9 1.40.0

(plus the corresponding yarn.lock update).

Also: exclude claude-fable-5 from tool-supporting models (ai-proxy)

Fixing the build let the full test matrix run for the first time in a while, which unmasked a pre-existing failure in the required LLM Integration Tests (ai-proxy) job: Anthropic's new claude-fable-5 fails the tool-support sweep. It has always-on thinking — it rejects the thinking: {type: "disabled"} param that LangChain sends by default, and it requires thinking blocks to be replayed verbatim on multi-turn tool calls, which the proxy's OpenAI-format message conversion drops. Adding it to ANTHROPIC_UNSUPPORTED_MODELS gives users a clear AIModelNotSupportedError upfront instead of provider 400s (same pattern as the o1/o3/o4 exclusions on the OpenAI side). Proper Fable support would need thinking-block passthrough in the wire format — a separate feature.

This has to land here rather than in its own PR because the integration job can't go green on any branch until this PR's build fix is on it.

Verification

lerna run build --scope @forestadmin/workflow-executor --include-dependencies now succeeds (tsc clean) where it previously failed. ai-proxy unit tests (404) and lint pass; the previously failing datasource-mongo and OpenAI-503 failures cleared on re-run (flaky/transient).

This is independent of #1641 (PRD-496) — it unblocks the workflow-executor build on main for everyone.

🤖 Generated with Claude Code

Note

Align @forestadmin/* dependencies in workflow-executor with workspace versions

Bumps three direct dependencies in package.json to match the rest of the workspace: @forestadmin/agent-client to 1.6.0, @forestadmin/ai-proxy to 1.11.0, and @forestadmin/forestadmin-client to 1.40.0. The lockfile is updated accordingly.

Changes since #1643 opened

  • Added 'claude-fable-5' to the ANTHROPIC_UNSUPPORTED_MODELS constant in the ai-proxy package with documentation explaining the incompatibility is due to always-on thinking requirements and mandatory verbatim replay of thinking blocks across tool calls, and added test cases verifying that isModelSupportingTools correctly identifies 'claude-fable-5' with provider 'anthropic' as unsupported while confirming 'claude-opus-4-8' remains supported [655833a]
  • Reformatted comment documentation for the ANTHROPIC_UNSUPPORTED_MODELS constant [2e56cd2]

Macroscope summarized 13493e0.

The pinned versions lagged the workspace and lacked APIs the source
uses (AiClient/BaseChatModel from ai-proxy, ServerUtils from
forestadmin-client, Collection.getOne from agent-client), so
workflow-executor:build failed in CI. Bump them to the current
workspace versions so it builds against the same sources every other
package does.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@qltysh

qltysh Bot commented Jun 10, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

claude-fable-5 has always-on thinking: it rejects the
thinking: {type: 'disabled'} param LangChain sends by default, and
requires thinking blocks to be replayed verbatim on multi-turn tool
calls, which the proxy's OpenAI-format message conversion drops.
Excluding it gives a clear AIModelNotSupportedError upfront instead of
provider 400s, and unblocks the llm.integration CI job.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread packages/ai-proxy/src/supported-models.ts Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@hercemer42
hercemer42 merged commit a901753 into main Jun 10, 2026
30 checks passed
@hercemer42
hercemer42 deleted the fix/workflow-executor-align-dep-versions branch June 10, 2026 09:35
forest-bot added a commit that referenced this pull request Jun 10, 2026
## @forestadmin/ai-proxy [1.11.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/ai-proxy@1.11.0...@forestadmin/ai-proxy@1.11.1) (2026-06-10)

### Bug Fixes

* **workflow-executor:** align @forestadmin/* deps with the workspace ([#1643](#1643)) ([a901753](a901753))
forest-bot added a commit that referenced this pull request Jun 10, 2026
# @forestadmin/workflow-executor 1.0.0 (2026-06-10)

### Bug Fixes

* **workflow-executor:** align @forestadmin/* deps with the workspace ([#1643](#1643)) ([a901753](a901753))

### Features

* **executor:** introduce workflow executor ([#1564](#1564)) ([1545069](1545069))

### Dependencies

* **@forestadmin/agent-client:** upgraded to 1.6.1
* **@forestadmin/ai-proxy:** upgraded to 1.11.1
* **@forestadmin/forestadmin-client:** upgraded to 1.40.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants