fix(cohorts): Populate rules_data on a cohort's segment by khvn26 · Pull Request #8579 · Flagsmith/flagsmith

khvn26 · 2026-09-23T11:48:11Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Closes #8507.

How did you test this code?

Unit tests.

vercel · 2026-09-23T11:48:13Z

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated
docs	Ignored	Preview	Sep 23, 2026 12:14pm UTC
flagsmith-frontend-preview	Ignored	Preview	Sep 23, 2026 12:14pm UTC
flagsmith-frontend-staging	Ignored	Preview	Sep 23, 2026 12:14pm UTC

coderabbitai · 2026-09-23T11:48:18Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e1be25ab-7e90-4ecb-9a85-9b16105418ce

📥 Commits

Reviewing files that changed from the base of the PR and between 3a887a5 and 42ec82e.

📒 Files selected for processing (2)

api/cohorts/migrations/0006_backfill_cohort_segment_rules_data.py
api/tests/unit/cohorts/test_migrations.py

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Walkthrough

create_cohort now creates the cohort before its managed segment. The segment receives rules_data with an ALL rule and an IS_SET condition on the cohort’s system trait. The cohort is then linked to the segment and saved. A data migration backfills eligible existing cohort segments. Tests cover the creation flow and migration. Six event catalogue source references are updated.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 42ec8

New cohorts now get rule data on their managed segment, and a data migration backfills existing live cohort segments with the same rule. That covers both requirements from the linked issue. The migration leaves deleted, unmanaged and already-populated segments unchanged. No outstanding issues block merging.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-09-23T11:53:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (f5345d1) to head (42ec82e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8579   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files        1631     1633    +2     
  Lines       66920    66974   +54     
=======================================
+ Hits        66123    66177   +54     
  Misses        797      797

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

A cohort creates its segment's rule and condition as rows, and is the one path that leaves `Segment.rules_data` unset. The backfill migration only covered segments that existed when it ran, so every cohort created since carries none. That is invisible today, since evaluation reads the rows. It stops being invisible the moment anything reads the field instead: a segment with no rules matches nobody, so cohort membership would quietly stop applying. Build the cohort unsaved to learn the trait key its membership is keyed on, so the segment can be created carrying its rules in one write.

github-actions · 2026-09-23T12:03:52Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-e2e:pr-8579`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-frontend:pr-8579`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api-test:pr-8579`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-8579`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-8579`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api:pr-8579`	Finished ✅	Results ✅

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2ab1e43b-ef9a-493e-a6c3-cbc9d4571354

📥 Commits

Reviewing files that changed from the base of the PR and between f5345d1 and 3a887a5.

📒 Files selected for processing (3)

api/cohorts/services.py
api/tests/unit/cohorts/test_services.py
docs/docs/deployment-self-hosting/observability/_events-catalogue.md

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

github-actions · 2026-09-23T12:10:17Z

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20690 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute
42ec82e
🔄 Run: #20690 (attempt 1)

🗂️ Previous results

✅ private-cloud · depot-ubuntu-latest-16 — run #20690 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 4 suites
58.6 seconds
42ec82e
🔄 Run: #20690 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20690 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
39.9 seconds
42ec82e
🔄 Run: #20690 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20690 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
34.6 seconds
42ec82e
🔄 Run: #20690 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20688 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

3 passed

Details

3 tests across 3 suites
51.7 seconds
3a887a5
🔄 Run: #20688 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #20688 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
56.2 seconds
3a887a5
🔄 Run: #20688 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20688 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
46.4 seconds
3a887a5
🔄 Run: #20688 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20688 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
41.8 seconds
3a887a5
🔄 Run: #20688 (attempt 1)

github-actions · 2026-09-23T12:10:52Z

Visual Regression

19 screenshots compared. See report for details.
View full report

github-actions Bot added api Issue related to the REST API fix docs Documentation updates labels Sep 23, 2026

vercel Bot deployed to Preview – docs September 23, 2026 11:49 View deployment

khvn26 force-pushed the fix/cohort-segment-rules-data branch from 2c745eb to 83f58f6 Compare September 23, 2026 11:58

github-actions Bot added fix and removed fix docs Documentation updates labels Sep 23, 2026

chore: Update documentation artefacts

3a887a5

github-actions Bot added the docs Documentation updates label Sep 23, 2026

vercel Bot deployed to Preview – docs September 23, 2026 12:00 View deployment

khvn26 marked this pull request as ready for review September 23, 2026 12:03

khvn26 requested review from a team as code owners September 23, 2026 12:03

khvn26 requested review from matthewelwell and removed request for a team September 23, 2026 12:03

github-actions Bot removed fix docs Documentation updates labels Sep 23, 2026

github-actions Bot added the fix label Sep 23, 2026

coderabbitai Bot reviewed Sep 23, 2026

View reviewed changes

Comment thread api/cohorts/services.py

fix(cohorts): backfill rules_data on existing cohort segments

42ec82e

github-actions Bot added docs Documentation updates and removed fix labels Sep 23, 2026

github-actions Bot added fix and removed docs Documentation updates labels Sep 23, 2026

Conversation

khvn26 commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercel Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

codecov Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Uh oh!

github-actions Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

khvn26 commented Sep 23, 2026 •

edited

Loading

vercel Bot commented Sep 23, 2026 •

edited

Loading

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading

codecov Bot commented Sep 23, 2026 •

edited

Loading

github-actions Bot commented Sep 23, 2026 •

edited

Loading

github-actions Bot commented Sep 23, 2026 •

edited

Loading

github-actions Bot commented Sep 23, 2026 •

edited

Loading