Skip to content

fix: gate experiment freeze behind feature flag and unblock inputs during loading#7919

Merged
Zaimwa9 merged 2 commits into
mainfrom
fix/feature-update-input-frozen-during-experiment-request
Jun 30, 2026
Merged

fix: gate experiment freeze behind feature flag and unblock inputs during loading#7919
Zaimwa9 merged 2 commits into
mainfrom
fix/feature-update-input-frozen-during-experiment-request

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Inputs were frozen on experiment loading first load (even without flag)
  • Skip entirely freeze hook if experimental_flags is disabled
  • Removed isLoading from inputs

How did you test this code?

  • Added tests
  • Tested in parallel prod and local against prod

@Zaimwa9 Zaimwa9 requested a review from matthewelwell June 30, 2026 15:59
@vercel

vercel Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jun 30, 2026 4:00pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jun 30, 2026 4:00pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jun 30, 2026 4:00pm

Request Review

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 30, 2026 15:59
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team June 30, 2026 15:59
@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jun 30, 2026
@github-actions

github-actions Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7919 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7919 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7919 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7919 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7919 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7919 Finished ✅ Results ✅

@github-actions github-actions Bot added the fix label Jun 30, 2026
matthewelwell
matthewelwell approved these changes Jun 30, 2026
View reviewed changes

@matthewelwell matthewelwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested specific issue this sets out to resolve, and the code looks reasonable.

@github-actions

github-actions Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 3 suites
duration  11.8 seconds
commit  89a2b54
info  🔄 Run: #17973 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  42.8 seconds
commit  89a2b54
info  🔄 Run: #17973 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  11.2 seconds
commit  89a2b54
info  🔄 Run: #17973 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  57.2 seconds
commit  89a2b54
info  🔄 Run: #17973 (attempt 1)

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

17 screenshots compared. See report for details.
View full report

@Zaimwa9 Zaimwa9 merged commit 5e0043d into main Jun 30, 2026
30 of 31 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/feature-update-input-frozen-during-experiment-request branch June 30, 2026 16:12
@flagsmith-engineering flagsmith-engineering Bot mentioned this pull request Jun 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes
@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees

@kyle-ssg kyle-ssg

@matthewelwell matthewelwell

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zaimwa9 @matthewelwell @kyle-ssg