fix(mypy): narrow compressed feature_states to bytes in dynamodb mapper test#7916
Merged
Conversation
The new dynamodb mapper test passed result.document["feature_states"] (a DocumentValue union) straight to gzip.decompress, which mypy rejects. Narrow it with an isinstance assert, matching the sibling tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Zaimwa9
approved these changes
Jun 30, 2026
Contributor
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7916 +/- ##
==========================================
+ Coverage 98.56% 98.62% +0.06%
==========================================
Files 1488 1488
Lines 58561 58590 +29
==========================================
+ Hits 57720 57784 +64
+ Misses 841 806 -35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Visual Regression17 screenshots compared. See report for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Follow-up to #7915. The new test
test_map_environment_to_compressed_environment_document__mv_option_with_key__key_preservedpassedresult.document["feature_states"]— aDocumentValueunion — directly togzip.decompress, which mypy rejects:Narrow the value to
byteswith anisinstanceassert before decompressing, matching the sibling*_returns_compressed_fieldstests.How did you test this code?
mypy tests/unit/util/mappers/test_unit_mappers_dynamodb.py→Success: no issues found.test_map_environment_to_compressed_environment_document__mv_option_with_key__key_preservedstill passes.