ci(renovate): fix pip managers bypassing security-only mode#333
Merged
Conversation
The packageRule that re-enabled git-submodules also listed the pip managers, which overrode security:only-security-updates and let normal (non-security) PRs through for Python deps (e.g. #325). Narrow the re-enable to git-submodules only, drop the now-redundant disable rule (the security preset already handles it), and switch to json5 so the file can carry explanatory comments. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3a5f27d |
There was a problem hiding this comment.
Code Review
This pull request replaces the Renovate configuration file with a JSON5 version (renovate.json5) and updates the package rules. Specifically, it restricts normal-flow updates to only git-submodules and removes various Python package managers (such as pip and poetry) from normal updates to ensure only security-related updates are processed for Python dependencies. There are no review comments, so I have no feedback to provide.
emyller
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #316 switched
extendstosecurity:only-security-updates, but we kept getting non-security renovate PRs for Python deps (e.g. #325, bumpingdatamodel-code-generatorfrom 0.33.0 → 0.66.0).The cause was the second
packageRule:{ "matchManagers": ["git-submodules", "pip_requirements", "pip-compile", "pep621", "poetry"], "enabled": true }packageRulesare evaluated in order and later rules override earlier ones, so this rule re-enabled every normal update type for the pip managers and effectively short-circuited the security-only preset.Changes
git-submodulesonly — that's the one manager we genuinely want to keep updating outside the security flow (engine-test-data submodule).security:only-security-updatesalready disables normal-flow updates via:disableRenovate.renovate.json→renovate.json5so the config can carry inline comments explaining what each block does, including a warning at the re-enable rule so we don't accidentally re-introduce the pip-manager bypass.Security PRs are unaffected — they flow through the
vulnerabilityAlertsblock, which is evaluated separately frompackageRules.Test plan
renovate.json5(it's listed as a supported filename — https://docs.renovatebot.com/configuration-options/)pip_requirements/pep621/poetrypackages🤖 Generated with Claude Code