Repository navigation
Suppress trace events for internal metadata transactions - #9212
Open
MochalovAlexey wants to merge 1 commit into
Open
MochalovAlexey wants to merge 1 commit into
MochalovAlexey wants to merge 1 commit into
Conversation
hvlad
reviewed
Oct 14, 2026
| { | ||
| if (!att_meta_transaction) | ||
| { | ||
| // TRA_meta is not stored in tra_flags by TRA_start(), it's set below after unlinkFromAttachment |
Member
There was a problem hiding this comment.
Why not fix it in TRA_start ? Set same flag two times looks weird, at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suppresses transaction start and end (commit/rollback) trace events for internal metadata transactions, which started appearing after the metadata cache was introduced.
The TRA_meta flag is used to exclude these internal transactions from transaction start and end tracing.