Firebird 5.0.4 missing LC_RPATH on macOS

[hmoffatt]

The macOS build of Firebird 5.0.4 is missing the LC_RPATH command that was in previous builds, meaning that libfbclient.dylib can't find libtommath.dylib.

5.0.3 has this rpath set but 5.0.4 is missing it:

Load command 18
          cmd LC_RPATH
      cmdsize 32
         path @loader_path/.. (offset 12)

The link to libtommath depends on on this rpath:

Load command 18
           cmd LC_LOAD_DYLIB
       cmdsize 56
          name @rpath/lib/libtommath.dylib (offset 24)
    time stamp 2 Thu Jan  1 10:00:02 1970
       current version 1.41.0

[hmoffatt]

Also affects the plugins libEngine13.dylib etc, which now can't find libfbclient.dylib or libtommath.dylib or libtomcrypt.dylib.

I tried to add the missing rpath with install_name_tool but there is not enough space. Changing the load path from @rpath/lib/... to @loader_path (etc) works but has to be done in each individual library.

[hmoffatt]

@asfernandes looks possibly due to c449ec8

[hmoffatt]

This makes 5.0.4 unusable as a framework on Mac, despite containing a security fix.

[asfernandes]

Please test build from https://github.com/FirebirdSQL/firebird/actions/runs/31348329681 or next v5 snapshot.

[asfernandes]

No response. Considering as fixed.

[hmoffatt]

Sorry I've been away from my Mac and haven't had a chance to verify this. I will do next week.