Compare value length to used length () in reading data from message buffer.#297
Merged
MichalPrincNXP merged 3 commits intoJul 26, 2022
Merged
Conversation
…uffer. Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
2 tasks
we need be at the end of already written data. Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
2 tasks
Contributor
|
I added my comments, basically it looks great, thank you very much for the hard work |
Contributor
Member
Author
|
I don't see any of your comments in this PR. Did you send them? |
amgross
reviewed
Jul 13, 2022
MichalPrincNXP
approved these changes
Jul 15, 2022
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Hadatko
force-pushed
the
feature/improve_cursor
branch
from
c946c46 to
0767073
Compare
Member
Author
|
@amgross Is it ok now? |
amgross
approved these changes
Jul 24, 2022
MichalPrincNXP
approved these changes
Jul 26, 2022
MichalPrincNXP
approved these changes
Jul 26, 2022
MichalPrincNXP
approved these changes
Jul 26, 2022
Member
|
Thanks for the effort! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cervenka Dusan cervenka@acrios.com
Pull request
Choose Correct
Describe the pull request
This should cover cases when we will try read more data that we received.
To Reproduce
Expected behavior
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context