Skip to content

Stabilize PgPool acquireTimeout tests under load - #9744

Closed
tim-smart wants to merge 39 commits into
v4/next-minorfrom
fix/pgpool-acquire-timeout-test-setup
Closed

Stabilize PgPool acquireTimeout tests under load#9744
tim-smart wants to merge 39 commits into
v4/next-minorfrom
fix/pgpool-acquire-timeout-test-setup

Conversation

@tim-smart

@tim-smart tim-smart commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

The two acquireTimeout tests in PgPool.in-process.test.ts open their first socket inside a checkout bounded by the 100ms acquireTimeout. Under load, cold socket startup takes 40 to 490ms on Bun, so the timeout sometimes fires during setup, before the scenario under test starts.

Both tests now set minConnections: 1 and poll sql.poolStats until an idle connection exists before reserving the connection or forking SELECT 1. Background creation isn't bound by acquireTimeout. The wait gives up after about 5s and fails with the last pool stats. The timeout assertions and write counts are unchanged, and nothing in src changed.

Validation on Bun 1.4.0 (the CI version), 72 runs of the file at 12 concurrent processes:

  • base ee781bbddd: 10/72 runs failed (8 exhausted-pool, 3 multiplexed)
  • this branch: 0/72

The file also passes 5/5 runs under Node.

Any change to how acquireTimeout relates to connectTimeout in production code belongs in a separate PR.

Closes EFF-2768

fubhy and others added 30 commits October 21, 2026 22:07
@fubhy @claude @tim-smart
Type received and forwarded HTTP request methods as open strings (#8766)
5b91ca6 
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Tim Smart <hello@timsmart.co>
@fubhy @claude @tim-smart
Type Atom.Serializable encode/decode as Schema.Json (#8763)
2084e1e 
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Tim Smart <hello@timsmart.co>
@effect-bot @tim-smart
Support duplex additional child-process file descriptors (#8905)
1458efd
@sledorze @effect-bot @tim-smart
Add an explicit maxDepth option to Context.makeUnsafe (#8969)
c6db70a 
Co-authored-by: Effect Bot <tech-ops@effectful.co>
@Tarekkharsa @claude
@effect-bot @tim-smart
Export HttpClient.isTransientError and isTransientResponse (#9059)
892b9a8 
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Effect Bot <tech-ops@effectful.co>
@effect-bot @fubhy
@claude @tim-smart @sledorze @Tarekkharsa
Add pool occupancy stats to Pool, PgPool, and PgClient (#9090)
49c4651 
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Tim Smart <hello@timsmart.co>
Co-authored-by: Stéphane Le Dorze <stephane.ledorze@gmail.com>
Co-authored-by: Tarekkharsa <47394961+Tarekkharsa@users.noreply.github.com>
@effect-bot @tim-smart
Add request-level dependencies to McpServer (#9154)
8639686 
Co-authored-by: Tim Smart <hello@timsmart.co>
@bezff Viacheslav
@effect-bot @tim-smart
fix(sql): load filesystem migrations from their own module (#9157)
7303d6e 
Co-authored-by: Viacheslav <bezff@MacBook-Pro-3.local>
Co-authored-by: Effect Bot <tech-ops@effectful.co>
@jem-computer Jem Gold
@claude @effect-bot @tim-smart
ai: TypeSafe images and Box questions via Decision.locate (#9177)
a2aa87e 
Co-authored-by: Jem Gold <jem@portola.ai>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Effect Bot <tech-ops@effectful.co>
Co-authored-by: Tim Smart <hello@timsmart.co>
@tim-smart @schutzelaars @effect-bot
Acknowledge discarded RPC calls before running handlers (#9182)
50dbb47 
Co-authored-by: Juliaan <76615135+schutzelaars@users.noreply.github.com>
Co-authored-by: Effect Bot <tech-ops@effectful.co>
@effect-bot @tim-smart
fix(persistence): isolate stores on KeyValueStore and Redis backings (#…
e02fb9e 
…9223)

Co-authored-by: Tim <hello@timsmart.co>
@effect-bot @tim-smart
Fix Redis persisted queue claim ownership (#9229)
5f92565 
Co-authored-by: Tim Smart <hello@timsmart.co>
@okarin1511 @claude
@effect-bot @tim-smart
Render inherited CLI flags in their own help section with formatter c…
6d154e2 
…ollapse options (#9276)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Effect Bot <tech-ops@effectful.co>
@jpowersdev @effect-bot @tim-smart
Add schema-aware streaming CSV encoding and decoding (#9291)
7b17c0b 
Co-authored-by: Effect Bot <tech-ops@effectful.co>
Co-authored-by: Tim <hello@timsmart.co>
@effect-bot @tim-smart
Expose migration-free encoded SQL message storage construction (#9330)
e88e01c
@effect-bot @tim-smart
Bound synchronous Node readable and socket drains (#9327)
52e2f79 
Co-authored-by: Tim Smart <hello@timsmart.co>
@jpowersdev @tim-smart
Set column to undefined on CSV header errors (#9427)
c22900d
@tim-smart
Wait for failure-suspended workflow activity replay in test (#9456)
a2df397
@effect-bot @tim-smart
Add Unhandled logging option to ignore combinators (#9510)
47b8d18
@effect-bot @tim-smart
Report unobserved resource release defects (#9388)
288ed15
@bezff @effect-bot @tim-smart
Fix sql.insert and sql.updateValues crashing on an empty list (#9453)
ef089c0 
Co-authored-by: Effect Bot <tech-ops@effectful.co>
@effect-bot @tim-smart
Restore Anthropic spec fetching and schema regeneration (#9509)
b4f379a
@jpowersdev @effect-bot @tim-smart
Add Glob module and portable FileSystem.glob (#9438)
3cc3426 
Co-authored-by: Effect Bot <tech-ops@effectful.co>
Co-authored-by: Tim Smart <hello@timsmart.co>
@jayhemnani9910 @effect-bot @tim-smart
Fix TOML inline tables and arrays being extended after definition (#9537
7fd866d 
)

Co-authored-by: Effect Bot <tech-ops@effectful.co>
@jayhemnani9910 @effect-bot @tim-smart
Fix TOML multiline strings that end with quotes before the delimiter (#…
4c35c79 
…9532)

Co-authored-by: Effect Bot <tech-ops@effectful.co>
@tim-smart
Detect unsupported FetchHttpClient streaming request bodies (#9567)
dda030a
@tim-smart
Cover Locate decisions through DecisionModel.decideSettled
dc0c01f
@tim-smart
Raise pnpm fetch timeout for large CI tarball downloads (#9627)
7a61558
@fubhy @tim-smart
Replace effect/Crypto with per-family effect/crypto modules (#9126)
d51b02e 
Co-authored-by: Tim Smart <hello@timsmart.co>
@bezff Viacheslav
@effect-bot @tim-smart
fix(http): send stored cookies only to the matching host (#9614)
2ddba52 
Co-authored-by: Viacheslav <bezff@MacBook-Pro-3.local>
Co-authored-by: Effect Bot <tech-ops@effectful.co>
Co-authored-by: Tim Smart <hello@timsmart.co>
@effect-bot
effect-bot force-pushed the v4/next-minor branch 3 times, most recently from ed5e85c to 1b0f32b Compare October 21, 2026 22:39
@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 39.18 KB 39.18 KB 0.00 KB (0.00%)
basic.ts 7.08 KB 7.08 KB 0.00 KB (0.00%)
batching.ts 10.95 KB 10.95 KB 0.00 KB (0.00%)
brand.ts 6.71 KB 6.71 KB 0.00 KB (0.00%)
cache.ts 11.39 KB 11.39 KB 0.00 KB (0.00%)
config.ts 22.55 KB 22.55 KB 0.00 KB (0.00%)
differ.ts 21.70 KB 21.70 KB 0.00 KB (0.00%)
http-client.ts 26.47 KB 26.47 KB 0.00 KB (0.00%)
http-router.ts 35.74 KB 35.74 KB 0.00 KB (0.00%)
logger.ts 11.73 KB 11.73 KB 0.00 KB (0.00%)
metric.ts 9.32 KB 9.32 KB 0.00 KB (0.00%)
optic.ts 6.93 KB 6.93 KB 0.00 KB (0.00%)
pubsub.ts 15.83 KB 15.83 KB 0.00 KB (0.00%)
queue.ts 12.65 KB 12.65 KB 0.00 KB (0.00%)
schedule.ts 11.63 KB 11.63 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 13.89 KB 13.89 KB 0.00 KB (0.00%)
schema-binary.ts 40.71 KB 40.71 KB 0.00 KB (0.00%)
schema-class.ts 21.41 KB 21.41 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 32.37 KB 32.37 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 27.57 KB 27.57 KB 0.00 KB (0.00%)
schema-string-transformation.ts 15.13 KB 15.13 KB 0.00 KB (0.00%)
schema-string.ts 12.14 KB 12.14 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.07 KB 16.07 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 38.70 KB 38.70 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 25.80 KB 25.80 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 20.63 KB 20.63 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 20.82 KB 20.82 KB 0.00 KB (0.00%)
schema-toFormatter.ts 20.92 KB 20.92 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 25.51 KB 25.51 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 20.92 KB 20.92 KB 0.00 KB (0.00%)
schema.ts 20.59 KB 20.59 KB 0.00 KB (0.00%)
stm.ts 13.93 KB 13.93 KB 0.00 KB (0.00%)
stream.ts 10.18 KB 10.18 KB 0.00 KB (0.00%)

@effect-bot
effect-bot force-pushed the v4/next-minor branch 18 times, most recently from 89027bc to 1d9771d Compare October 22, 2026 00:17
@tim-smart tim-smart mentioned this pull request Oct 22, 2026
Closed
@effect-bot
effect-bot force-pushed the v4/next-minor branch 3 times, most recently from 16cc41b to c76ac0e Compare October 22, 2026 02:26
@tim-smart tim-smart closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.