Skip to content

Fix silent 404s when a path parameter is longer than 100 characters - #9447

Merged
tim-smart merged 5 commits into
Effect-TS:mainfrom
bezff:fix/http-param-length
Oct 17, 2026
Merged

tim-smart merged 5 commits into
Effect-TS:mainfrom
bezff:fix/http-param-length

Conversation

@bezff

@bezff bezff commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

The matcher already skips path parameters longer than maxParamLength, so the miss looked like a missing route. RouteNotFound now names maxParamLength and the configured limit. The limit (default 100) and the 404 response are unchanged: a longer parameter still does not match.

Closes #5059
Closes EFF-2384

the matcher already skips those params, so the miss looked like a missing route. RouteNotFound now names maxParamLength.

Fixes Effect-TS#5059
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a7ea1cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-cloudflare Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/graphql-generator Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-janitor effect-janitor Bot added the 4.0 label Oct 17, 2026
effect-janitor[bot]
effect-janitor Bot previously approved these changes Oct 17, 2026
Comment thread packages/effect/src/http/FindMyWay/internal/router.ts Outdated
description is omitted when there is no param limit, and the test narrows the flipped error.
effect-janitor[bot]
effect-janitor Bot previously approved these changes Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭😭😭

effect-janitor[bot]
effect-janitor Bot previously approved these changes Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 39.02 KB 39.02 KB 0.00 KB (0.00%)
basic.ts 7.02 KB 7.02 KB 0.00 KB (0.00%)
batching.ts 10.73 KB 10.73 KB 0.00 KB (0.00%)
brand.ts 6.71 KB 6.71 KB 0.00 KB (0.00%)
cache.ts 11.26 KB 11.26 KB 0.00 KB (0.00%)
config.ts 22.44 KB 22.44 KB 0.00 KB (0.00%)
differ.ts 21.54 KB 21.54 KB 0.00 KB (0.00%)
http-client.ts 23.93 KB 23.93 KB 0.00 KB (0.00%)
http-router.ts 35.59 KB 35.48 KB +0.11 KB (+0.31%)
logger.ts 11.60 KB 11.60 KB 0.00 KB (0.00%)
metric.ts 9.08 KB 9.08 KB 0.00 KB (0.00%)
optic.ts 6.93 KB 6.93 KB 0.00 KB (0.00%)
pubsub.ts 15.68 KB 15.68 KB 0.00 KB (0.00%)
queue.ts 12.52 KB 12.52 KB 0.00 KB (0.00%)
schedule.ts 11.73 KB 11.73 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 13.80 KB 13.80 KB 0.00 KB (0.00%)
schema-binary.ts 40.48 KB 40.48 KB 0.00 KB (0.00%)
schema-class.ts 21.22 KB 21.22 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 32.31 KB 32.31 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 27.50 KB 27.50 KB 0.00 KB (0.00%)
schema-string-transformation.ts 14.95 KB 14.95 KB 0.00 KB (0.00%)
schema-string.ts 12.05 KB 12.05 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.21 KB 16.21 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 38.54 KB 38.54 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 25.60 KB 25.60 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 20.47 KB 20.47 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 20.67 KB 20.67 KB 0.00 KB (0.00%)
schema-toFormatter.ts 20.77 KB 20.77 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 25.40 KB 25.40 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 20.76 KB 20.76 KB 0.00 KB (0.00%)
schema.ts 20.41 KB 20.41 KB 0.00 KB (0.00%)
stm.ts 13.79 KB 13.79 KB 0.00 KB (0.00%)
stream.ts 10.05 KB 10.05 KB 0.00 KB (0.00%)

@tim-smart
tim-smart merged commit 915117b into Effect-TS:main Oct 17, 2026
10 of 11 checks passed

This branch is waiting to be deployed

1 waiting deployment
fork — a7ea1cff Waiting Oct 17, 2026 by effect-bot via approval-gate #20614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpApiEndpoint: setPath silently decides to cap path parameters to 100 characters

3 participants