Repository navigation
Fix silent 404s when a path parameter is longer than 100 characters - #9447
Merged
Merged
Conversation
the matcher already skips those params, so the miss looked like a missing route. RouteNotFound now names maxParamLength. Fixes Effect-TS#5059
🦋 Changeset detectedLatest commit: a7ea1cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
description is omitted when there is no param limit, and the test narrows the flipped error.
bezff
commented
Oct 17, 2026
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matcher already skips path parameters longer than
maxParamLength, so the miss looked like a missing route.RouteNotFoundnow namesmaxParamLengthand the configured limit. The limit (default 100) and the 404 response are unchanged: a longer parameter still does not match.Closes #5059
Closes EFF-2384