Skip to content

Adding geomin to rotations#64

Merged
desilinguist merged 6 commits into
masterfrom
feature/add-geomin
Oct 29, 2020
Merged

Adding geomin to rotations#64
desilinguist merged 6 commits into
masterfrom
feature/add-geomin

Conversation

@jbiggsets

@jbiggsets jbiggsets commented Sep 28, 2020

Copy link
Copy Markdown
Collaborator

This is a PR to add orthogonal and oblique geomin rotations to factor_analyzer's Rotator() class. It includes several tests to ensure that the output matches what we get from R's fa() function in psych (which relies on the GPArotation library).

The main change is adding a new objective _geomin_obj(). This should address #63 .

@codecov

codecov Bot commented Sep 28, 2020

Copy link
Copy Markdown

Codecov Report

Merging #64 into master will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   94.53%   95.11%   +0.58%     
==========================================
  Files           5        6       +1     
  Lines         824      963     +139     
==========================================
+ Hits          779      916     +137     
- Misses         45       47       +2     
Impacted Files Coverage Δ
factor_analyzer/test_utils.py 98.41% <ø> (ø)
factor_analyzer/rotator.py 95.60% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727bdc9...858dbff. Read the comment docs.

@jbiggsets jbiggsets changed the title [WIP] Adding geomin to rotations Adding geomin to rotations Sep 28, 2020
@jbiggsets jbiggsets requested a review from zeromh October 1, 2020 01:09

@zeromh zeromh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zeromh

zeromh commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator

@jbiggsets, just wondering if you have an estimate on when PR will be merged? Also are you planning a new release at some point?

@zeromh

zeromh commented Oct 29, 2020

Copy link
Copy Markdown
Collaborator

@jbiggsets @desilinguist ?
Do you have some idea of when this will be added?

@desilinguist desilinguist merged commit e3f7842 into master Oct 29, 2020
@desilinguist desilinguist deleted the feature/add-geomin branch October 29, 2020 23:05
@desilinguist desilinguist mentioned this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants