Adding geomin to rotations#64
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 94.53% 95.11% +0.58%
==========================================
Files 5 6 +1
Lines 824 963 +139
==========================================
+ Hits 779 916 +137
- Misses 45 47 +2
Continue to review full report at Codecov.
|
Collaborator
|
@jbiggsets, just wondering if you have an estimate on when PR will be merged? Also are you planning a new release at some point? |
Collaborator
|
@jbiggsets @desilinguist ? |
desilinguist
approved these changes
Oct 29, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to add orthogonal and oblique geomin rotations to
factor_analyzer'sRotator()class. It includes several tests to ensure that the output matches what we get from R'sfa()function inpsych(which relies on theGPArotationlibrary).The main change is adding a new objective
_geomin_obj(). This should address #63 .