This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Rebased Amazon main shopping sites - #5033
Merged
Merged
Conversation
Contributor
Author
|
Blocked by #4997 (comment) |
Contributor
Author
|
rebased |
Member
|
@J0WI lmk when this is ready for review again and I can check & merge |
Contributor
Author
|
@Hainish should already be ready. |
Member
|
@J0WI okay, I'll review next week (I'm off today) |
Contributor
Author
|
I also addressed #4997 (comment) now. |
Member
|
Some things have come up which means I'll have to postpone reviewing this till next week |
Member
|
Looks like ruleset validation isn't passing: |
Member
|
All the fetch tests look good, and I've looked over the ruleset changes, these look fine. Ready to merge once you remove |
- removed obsolete sis. - code style
Contributor
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #4997 and all issues mentioned there.
ping @fuglede @Hainish for review