Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added bewelcome.org with additional tests based on https://github.com… - #4587

Closed
thisismeonmounteverest wants to merge 13 commits into
EFForg:masterfrom
thisismeonmounteverest:bewelcome
Closed

thisismeonmounteverest wants to merge 13 commits into
EFForg:masterfrom
thisismeonmounteverest:bewelcome

Conversation

@thisismeonmounteverest

Copy link
Copy Markdown

Added tests mentioned in #4261.

@simison

simison commented Apr 10, 2016

Copy link
Copy Markdown

Git squashing would make this a bit prettier:
image

@J0WI

J0WI commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

There are also:
alpha.bewelcome.org
test.bewelcome.org
trac.bewelcome.org (refused)
fox.bewelcome.org (refused)
downloads.bewelcome.org (mismatched)
www.bewelco.me (mismatched)

The content on (www.)bewelco.me differs from bewelcome.org.

Please use comments to document all problematic domains on the top of the rule.
Our style guide requires tabs instead of spaces.

@Hainish Hainish added the top-1m label Aug 19, 2016
@J0WI

J0WI commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

@thisismeonmounteverest would you like to finish this?
Don't worry about squashing commits, we do this during merge.

@jeremyn

jeremyn commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

@thisismeonmounteverest Are you still interested in working on this?

@thisismeonmounteverest

Copy link
Copy Markdown
Author

If I don't have to do anything for it, yes. Otherwise drop it.

The process to get something in was way to complicated.

@jeremyn

jeremyn commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

Unfortunately, this ruleset would need more changes before we merge it. I'm closing the pull request based on your last comment, but I've noted the domains in issue #3069 in case anyone else wants to include them.

@jeremyn jeremyn closed this Dec 3, 2016
@jeremyn jeremyn mentioned this pull request Dec 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants