Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add script to trivialize some left-wildcard targets - #17855

Merged
Hainish merged 5 commits into
EFForg:masterfrom
cschanaj:script-to-trivialize-targets
Jun 6, 2019
Merged

Hainish merged 5 commits into
EFForg:masterfrom
cschanaj:script-to-trivialize-targets

Conversation

@cschanaj

@cschanaj cschanaj commented May 1, 2019 •

Copy link
Copy Markdown
Collaborator

this supersedes #17842 and is ready for review and merging. thanks.

P.S. there is no need to rush for the major release in #17711 .

cc @pipboy96 @zoracon @Hainish

@cschanaj
cschanaj requested review from Hainish and zoracon May 1, 2019 08:20
Comment thread utils/trivialize-rules/trivialize-targets.js
Comment thread utils/trivialize-rules/trivialize-targets.js
Comment thread utils/trivialize-rules/trivialize-targets.js Outdated
Comment thread utils/trivialize-rules/trivialize-targets.js Outdated
Comment thread utils/trivialize-rules/trivialize-targets.js Outdated
Comment thread utils/trivialize-rules/trivialize-targets.js Outdated
Comment thread utils/trivialize-rules/trivialize-targets.js Outdated
Comment thread utils/trivialize-rules/trivialize-targets.js
Comment thread utils/trivialize-rules/trivialize-targets.js Outdated
Comment thread utils/trivialize-rules/trivialize-targets.js
Comment thread utils/trivialize-rules/trivialize-targets.js Outdated
Comment thread utils/trivialize-rules/trivialize-targets.js
@pipboy96

pipboy96 commented May 1, 2019

Copy link
Copy Markdown
Contributor

@cschanaj Is there a reason to prefer " over '? Same issue exists in the extension itself. Both are used without any consistency.

@cschanaj

cschanaj commented May 1, 2019 •

Copy link
Copy Markdown
Collaborator Author

this directory use prettier as the preferred linter (a choice from its original author). I just follow his practices. You're right, single quote should used as per #16029 (comment)

@cschanaj

cschanaj commented Jun 5, 2019

Copy link
Copy Markdown
Collaborator Author

@Hainish would you be interested in looking into this, possibly before the next ruleset release?

@Hainish

Hainish commented Jun 6, 2019

Copy link
Copy Markdown
Member

I've reviewed and made a few changes here: #18062

@cschanaj please review my changes and make sure the clarifications are actually accurate. Otherwise, good to merge. Great work, and thanks for this!

@Hainish
Hainish merged commit be134ca into EFForg:master Jun 6, 2019
@cschanaj
cschanaj deleted the script-to-trivialize-targets branch June 7, 2019 04:37
@cschanaj cschanaj mentioned this pull request Jun 7, 2019
20 of 24 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants