Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

WASM implementation sometimes fails to find rules #18589

Closed

Description

@Bisaloo

Type: code issue

With EASE enabled, http://meta.unix.stackexchange.com/ leads to the interstitial page while we would expect it to lead to https://unix.meta.stackexchange.com/ because of:

<!-- meta.* sites moved to *.meta - we can safely redirect to their new equivalents, which support https -->
<!-- details: https://meta.stackexchange.com/questions/292058/network-wide-https-its-time -->
<rule from="^http://meta\.([\w-]+)\.stackexchange\.com/" to="https://$1.meta.stackexchange.com/" />

I think this used to work. Am I missing something obvious here?

Activity

  1. added
    EASEEncrypt all sites eligible (#16985)
    on Oct 18, 2019
  2. pipboy96 commented on Oct 18, 2019

    @pipboy96
    Contributor

    @Bisaloo I will try figuring this out.

  3. self-assigned this
    on Oct 18, 2019
  4. cschanaj commented on Oct 20, 2019

    @cschanaj
    Collaborator

    It is likely to be an issue with the way the WASM implementation handling the wildcards. It also affect browsing session outside of EASE since the last release 2019.6.27.

  5. removed their assignment
    on Oct 20, 2019
  6. changed the title [-]Rules don't work with EASE[/-] [+]WASM implementation sometimes fails to find rules[/+] on Oct 20, 2019
  7. removed
    EASEEncrypt all sites eligible (#16985)
    on Oct 20, 2019
  8. pipboy96 commented on Oct 20, 2019

    @pipboy96
    Contributor

    This is not EASE specific if I correctly understand, so I removed EASE label for now.

  9. cschanaj commented on Oct 20, 2019

    @cschanaj
    Collaborator

    cc @zoracon @Hainish I have submit a PR at EFForg/https-everywhere-lib-core#1 relate to this issue on WASM module wildcard rules handling.

  10. Hainish commented on Nov 7, 2019

    @Hainish
    Member

    Fixed - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions