Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

If possible, rewrite the rulesets in a way that does not require HTTPS->HTTPS rules. #10843

Closed
Closed
If possible, rewrite the rulesets in a way that does not require HTTPS->HTTPS rules.#10843

Description

@ghost
ghost
opened on Jul 1, 2017

Type: other

Related: #10839

Done

Activity

  1. cschanaj commented on Jul 2, 2017

    @cschanaj
    cschanaj
    on Jul 2, 2017
    Collaborator

    Noted that the following rulesets do not rewrite HTTPS.

    bfffe47dc9d0e3cc663ae55b4194150d7b2e7c996c753a16201aeece1ff526ae  Cato-Institute.xml
7a5412172a8a5c73ff51b177413b29539199397763dc5b11024ec0b7423df9c9  Epson.xml
f0da196f4b2f1f2a8fb0e7960c6e577b90781baf21e42dc677b041d13773f187  GoogleMaps.xml
b37bc0c3b107c55924fa5487231eab4004c6e6e6d581d7fac38ab2b1138c7d35  LiveJournal.xml
5f637cd0be002fb0f0cb2c3d13bc35d6baeef5ea76fccb62d93bf4d5b182bf9d  Tesco.xml
4a8a859f2bf60badb5d1f2363d4fb0c501ec63d8a5d11838e142afe913408375  Yandex.xml
667f0af26100508747674a3000fec0f25d4b73da00552894b743666bbba269c1  ZeniMax-Media.xml

  2. cschanaj commented on Jul 24, 2017

    @cschanaj
    cschanaj
    on Jul 24, 2017
    Collaborator

    Please also note the following rulesets found by the following command in #11024 (review).

    grep -Fl '^(?:http://(?:www\.)?|https://)' *.xml
    fa3af743b1c53d079a9203e4876402e083fa4f5541b37aafbc916dc5c7c455e6  Care-Net.xml
961a6238a3fbb95a5f04b424843a8797185dd067488186944281f9b8c5314502  CA-State-Board-of-Equalization.xml
3bd8a37cd7bae417e479bfce375448bc0a557c7cd71dda1697a78fc250d4501c  EarthLink.xml
edbf455dd9b2344758f0e3861ebfe53c956596a2b71a36bb782cbb5a379bf527  HealthCheckUSA.xml
9ef73c2c7642cb622145154e9b86859f1b55598fd5a97f29a9bde51764528fe6  MyEdAccount.Com.xml
944ee1959b21eb47077b1bad494a3be3985c59f18b472b2ea0c9204c34ce5a2c  MYEDDEBT.com.xml
6579a09fbc23ca93ce9956cd0c8c250f5a007a687a836e4a0b62a919c5744eb7  Volgistics.xml

    Also

    grep -F 'http(s):' *.xml
    1ef0c6ba2c29ec438decf608df47b2b325d19b3f9ced3f00c2e6e86201641661  sourcefoundry.org.xml

  3. cschanaj commented on Jul 28, 2017

    @cschanaj
    cschanaj
    on Jul 28, 2017
    Collaborator

    Also note that the following ruleset

    3d5bde747e8aaff058056b970800a53151f89006704db8cb2559e55f2ac8ef9b  ED.gov.xml

    found by

    grep -Fl '^(http://(www\.)?|https://)' *.xml

  4. Bisaloo commented on Aug 1, 2017

    @Bisaloo
    Bisaloo
    on Aug 1, 2017
    Collaborator

    #10087 updated basekit.com but the https->https rewrite can't be removed without breaking stuff.

  5. ghost closed this as completedon Aug 19, 2017

  6. cschanaj commented on Aug 20, 2017

    @cschanaj
    cschanaj
    on Aug 20, 2017
    Collaborator

    @koops76 why do you open re-opened this in a new issue #11993 for this?

  8. cschanaj commented on Aug 20, 2017

    @cschanaj
    cschanaj
    on Aug 20, 2017
    Collaborator

    @koops76 there are pages of issues listed behind the 3rd pages, I don't really agree this is a good idea if you keep doing this. some contributors might lose track of the progress of some issues.

  10. cschanaj commented on Aug 20, 2017

    @cschanaj
    cschanaj
    on Aug 20, 2017
    Collaborator

    @koops76 imagine if everyone is doing this because nobody notice their issues, it will be pretty bad since bugs report and other issues will never get to the top.

  12. jeremyn commented on Aug 21, 2017

    @jeremyn
    jeremyn
    on Aug 21, 2017
    Contributor

    @koops76 I agree with @cschanaj , please don't make duplicate issues. Aside from @cschanaj 's valid point of "what if everyone did this?", it also makes it harder to see the discussion around these problems like @Bisaloo 's and @cschanaj 's comments above.

    It's best to consider these collection/checklist issues as being for your own reference, not for general viewing, in which case it doesn't matter how far down the queue it falls.

    Please feel free to share any thoughts you have on making these issues more discoverable, if you want. Maybe adding certain GitHub labels would help?

  14. ghost reopened this on Aug 21, 2017

  15. jeremyn commented on Aug 21, 2017

    @jeremyn
    jeremyn
    on Aug 21, 2017
    Contributor

    I'm not sure how I would do that, if I wanted to. The project is almost entirely volunteer-driven except for a few paid EFF people who also have other responsibilities.

  16. 3 remaining items

  17. https-everywhere-bot commented on Oct 31, 2017

    @https-everywhere-bot
    https-everywhere-botBot
    on Oct 31, 2017

    I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

  18. https-everywhere-bot commented on Oct 31, 2017

    @https-everywhere-bot
    https-everywhere-botBot
    on Oct 31, 2017

    I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

  19. https-everywhere-bot commented on Oct 31, 2017

    @https-everywhere-bot
    https-everywhere-botBot
    on Oct 31, 2017

    I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

  20. https-everywhere-bot commented on Oct 31, 2017

    @https-everywhere-bot
    https-everywhere-botBot
    on Oct 31, 2017

    I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

  21. https-everywhere-bot commented on Oct 31, 2017

    @https-everywhere-bot
    https-everywhere-botBot
    on Oct 31, 2017

    I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

  22. https-everywhere-bot commented on Oct 31, 2017

    @https-everywhere-bot
    https-everywhere-botBot
    on Oct 31, 2017

    I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

  23. jeremyn commented on Oct 31, 2017

    @jeremyn
    jeremyn
    on Oct 31, 2017
    Contributor

    @strugee What's going on with the bot?

  24. https-everywhere-bot commented on Oct 31, 2017

    @https-everywhere-bot
    https-everywhere-botBot
    on Oct 31, 2017

    Thanks! Your edit helped me out. I'll take it from here now.

  25. strugee commented on Nov 1, 2017

    @strugee
    strugee
    on Nov 1, 2017
    Contributor

    @jeremyn yikes! That shouldn't be happening.

    Did you (un)check a bunch of boxes? If so I bet GitHub sent a bunch of edit events to the bot when that happened and the bot complained due to the missing issue type metadata. In theory this shouldn't happen as of #13294 landing but I wrote that PR pretty late at night, and I think I forgot to test the date handling code.

    If this sounds right to you I'll look into this and hopefully prepare a PR fixing it 👍

  26. jeremyn commented on Nov 1, 2017

    @jeremyn
    jeremyn
    on Nov 1, 2017
    Contributor

    @strugee This isn't my PR, I just noticed the bot having trouble. Maybe @koops76 could give more diagnostic information.

  28. jeremyn commented on Nov 1, 2017

    @jeremyn
    jeremyn
    on Nov 1, 2017
    Contributor

    @strugee See also issue #3069 which has a similar problem.

  29. strugee commented on Nov 2, 2017

    @strugee
    strugee
    on Nov 2, 2017
    Contributor

    Filed #13460 to fix this behavior.

  30. Bisaloo commented on Nov 8, 2018

    @Bisaloo
    Bisaloo
    on Nov 8, 2018
    Collaborator

    This is fixed by #16924 and #17043

  31. Bisaloo
    closed this as completedon Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions