feat(pre-commit): adds pre-commit linting, yaml-compliance checking, …#10
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
============================================
+ Coverage 17.88% 100.00% +82.11%
============================================
Files 4 3 -1
Lines 123 22 -101
============================================
Hits 22 22
+ Misses 101 0 -101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Matt-Carre
force-pushed
the
pre-commit-check-yaml
branch
from
5c82126 to
3636ca1
Compare
TBThomas56
reviewed
Jun 26, 2026
TBThomas56
reviewed
Jun 26, 2026
TBThomas56
reviewed
Jun 26, 2026
TBThomas56
requested changes
Jun 26, 2026
JamesDoingStuff
requested changes
Jun 26, 2026
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
Collaborator
There was a problem hiding this comment.
Good work! Got a few suggestions - hope you don't think me harsh, but you're getting the hang of this quickly so we have time to be thorough :)
Collaborator
|
Also, is there a reason for leaving file extensions off the scripts? I know they're not required, but I find them helpful to know what the contents looks like and to distinguish from binaries |
Matt-Carre
force-pushed
the
pre-commit-check-yaml
branch
6 times, most recently
from
c825a20 to
a7b23f6
Compare
JamesDoingStuff
previously requested changes
Jun 29, 2026
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
Collaborator
There was a problem hiding this comment.
Nice, just a couple of comments, mostly stylistic
TBThomas56
requested changes
Jun 30, 2026
Matt-Carre
force-pushed
the
pre-commit-check-yaml
branch
from
0a80703 to
510ad96
Compare
TBThomas56
reviewed
Jun 30, 2026
TBThomas56
requested changes
Jun 30, 2026
Matt-Carre
force-pushed
the
pre-commit-check-yaml
branch
from
510ad96 to
ee382ea
Compare
… searches key-value pairs
TBThomas56
force-pushed
the
pre-commit-check-yaml
branch
from
4801d8d to
37022f3
Compare
TBThomas56
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…yaml-regeneration, and environment variables