build: drop the unused zxing:javase dependency and decouple two cross-module javadoc refs#294
Merged
Merged
Conversation
… refs
Only zxing:core types are imported anywhere (the barcode/QR render
handlers); there are zero com.google.zxing.client references in src,
examples, or benchmarks, so javase was unused weight in every consumer's
transitive tree. Also neutralize two javadoc references that cross the
future engine/document module boundary:
- engine/debug/LayoutSnapshot.java: the {@link ...DocumentSession#layoutSnapshot()}
becomes {@code DocumentSession#layoutSnapshot()} so it does not fail to
resolve once engine and document are separate modules.
- font/FontLibrary.java: reword the getFont(name, PdfFont.class) example to
be backend-neutral so the core font javadoc stops naming a PDF type.
Production bytecode is byte-for-byte identical to the base branch; only the
pom dependency list and javadoc text change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The published
graph-composejar declarescom.google.zxing:javase, but nothing in the codebase uses it — it is dead weight in every consumer's transitive tree. Ahead of the 2.0 module split, two javadoc references also reach across the future engine ↔ document boundary and would stop resolving once those packages live in separate modules. This PR is pure hygiene: zero behaviour change.What changed
com.google.zxing:javase. Onlyzxing:coretypes are imported anywhere (the barcode/QR render handlers underdocument.backend.fixed.pdf.handlersand the legacyengine.render.pdf.ecs.handlers). There are zerocom.google.zxing.clientreferences insrc,examples, orbenchmarks.zxing:corestays; thezxing.versionproperty is retained for it.engine/debug/LayoutSnapshot.java— convert the engine→document{@link com.demcha.compose.document.api.DocumentSession#layoutSnapshot()}to{@code DocumentSession#layoutSnapshot()}, which reads the same but does not fail to resolve once engine and document are separate modules.font/FontLibrary.java— reword thegetFont(name, PdfFont.class)javadoc example to be backend-neutral ("keyed by the backend's ownClasstoken"), so the core font javadoc stops naming a PDF-backend type.Verification
./mvnw verify -pl .— green (full suite). The barcode/QR render tests pass withjavaseoff the classpath, which is the runtime proof the removal is safe, not just that its imports were unused.target/classesis byte-for-byte identical to the base branch (960 classes, emptydiff -rq). Production bytecode is unchanged; only the pom dependency list and javadoc source text differ../mvnw javadoc:javadoc -pl .— clean, zero warnings, confirming the{@code}conversions don't regress the doclint gate.