Skip to content

Add SecureCodeBox parser#4431

Closed
JohannesZahn wants to merge 29 commits into
DefectDojo:devfrom
secureCodeBox:parser-SCB
Closed

Add SecureCodeBox parser#4431
JohannesZahn wants to merge 29 commits into
DefectDojo:devfrom
secureCodeBox:parser-SCB

Conversation

@JohannesZahn

Copy link
Copy Markdown

Implemented a secureCodeBox Findings Import.

It is used in a secureCodeBox Hook to automatically import scans into DefectDojo (for scans that have no dedicated parser yet).

The Findings format is described here

See this issue for more information.

@github-actions

github-actions Bot commented May 3, 2021

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions

github-actions Bot commented May 3, 2021

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@valentijnscholten valentijnscholten changed the title Parser scb Add SecureCodeBox parser May 3, 2021

@damiencarol damiencarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a lot of comments, one is blocking (urlparse/hyperlink)

Comment thread dojo/fixtures/test_type.json
Comment thread dojo/tools/securecodebox/parser.py Outdated
Comment thread dojo/tools/securecodebox/parser.py Outdated
Comment thread dojo/tools/securecodebox/parser.py Outdated
Comment thread dojo/tools/securecodebox/parser.py Outdated
Comment thread dojo/tools/securecodebox/parser.py Outdated
Comment thread dojo/unittests/tools/test_securecodebox_parser.py Outdated
Comment thread dojo/unittests/scans/securecodebox/scb_one_vul.json
Comment thread dojo/tools/securecodebox/parser.py Outdated
@github-actions

github-actions Bot commented May 3, 2021

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

JohannesZahn and others added 5 commits May 3, 2021 13:59
Co-authored-by: Damien Carol <damien.carol@gmail.com>
Co-authored-by: Damien Carol <damien.carol@gmail.com>
Co-authored-by: Damien Carol <damien.carol@gmail.com>
@github-actions

github-actions Bot commented May 3, 2021

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Comment thread dojo/tools/securecodebox/parser.py Outdated

@madchap madchap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can completely remove the test_type.json file changes, it's all dynamic now.

@JohannesZahn

Copy link
Copy Markdown
Author

@madchap when I remove the test type json I can not find a SecureCodeBox Findings Import Test Type

@damiencarol

damiencarol commented May 11, 2021

Copy link
Copy Markdown
Contributor

@JohannesZahn it could means that the autoloading of your parser don't works. something is maybe missing

Comment thread dojo/unittests/tools/test_securecodebox_parser.py Outdated
@github-actions

github-actions Bot commented Jun 6, 2021

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@JohannesZahn

Copy link
Copy Markdown
Author

I am putting this on hold since we are currently experimenting with your new generic json parser

@JohannesZahn

Copy link
Copy Markdown
Author

We will probably not need this as we are now using the new generic JSON parser. So I will close the PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants