Skip to content

feat: Add JFrog Xray API Summary Artifact Scan configuration#14548

Merged
valentijnscholten merged 4 commits intoDefectDojo:bugfixfrom
Arthur-DTAG:bugfix
Mar 24, 2026
Merged

feat: Add JFrog Xray API Summary Artifact Scan configuration#14548
valentijnscholten merged 4 commits intoDefectDojo:bugfixfrom
Arthur-DTAG:bugfix

Conversation

@Arthur-DTAG
Copy link
Copy Markdown
Contributor

⚠️ Pre-Approval check ⚠️

Description

The deduplication does not work for JFrog Xray API Summary Artifact Scan.
Problem is just a missing config in the settings.dist.py.

Test results

No additional tests needed as far as i see

Documentation

Should be expected behaviour -> no additional docs needed.

Checklist

This checklist is for your information.

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • Bugfixes should be submitted against the bugfix branch.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.
  • Your code is Ruff compliant (see ruff.toml).
  • Your code is python 3.13 compliant.
  • If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
  • Model changes must include the necessary migrations in the dojo/db_migrations folder.
  • Add applicable tests to the unit tests.
  • Add the proper label to categorize your PR.

@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Mar 18, 2026
@valentijnscholten
Copy link
Copy Markdown
Member

@Maffooch This is (another) example of where a parser constructed unique id is helpful. But it's not used. But could be used.

@valentijnscholten
Copy link
Copy Markdown
Member

This can go ahead. Could you add a short note to the upgrade notes for 2.56.3 to make users aware they need to recompute the hash codes for this scanner? Example: docs/content/releases/os_upgrading/2.43.md

Added documentation for upgrading to DefectDojo version 2.56.3, focussing on JFrog Xray API Summary Artifact parser deduplication.
@github-actions github-actions bot added the docs label Mar 19, 2026
@Arthur-DTAG
Copy link
Copy Markdown
Contributor Author

Thanks!
I added come context to the docs and linked to the official docs on how to recompute the hashes for a parser.

Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten valentijnscholten added this to the 2.56.4 milestone Mar 23, 2026
@valentijnscholten valentijnscholten merged commit ccb4021 into DefectDojo:bugfix Mar 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants