Fix SonarQube API: raise clear error when project_name is None fixes …#14530
Closed
tejas0077 wants to merge 1 commit intoDefectDojo:bugfixfrom
Closed
Fix SonarQube API: raise clear error when project_name is None fixes …#14530tejas0077 wants to merge 1 commit intoDefectDojo:bugfixfrom
tejas0077 wants to merge 1 commit intoDefectDojo:bugfixfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a SonarQube API Scan Configuration is added without a Service Key 1,
the find_project method was called with None as the project name, causing
a confusing 400 error from SonarQube saying the component parameter is missing.
This fix adds a clear ValidationError with a helpful message when project_name
is None, so the user knows exactly what to fix instead of getting a cryptic error.
Also added the missing ValidationError import to api_client.py.
Fixes #13959
Test results
Manually traced the code path. The fix raises a clear ValidationError before
the API call is made when project_name is None.
Documentation
No documentation changes needed.