Add scan_date to import settings if overridden#14502
Merged
Conversation
valentijnscholten
approved these changes
Mar 12, 2026
Convert scan_date to ISO format string before storing in import_settings dict, which gets JSON-serialized. Raw datetime objects cause "TypeError: Object of type datetime is not JSON serializable". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests both cases: - User supplies scan_date: verifies it's stored as ISO string - No scan_date supplied: verifies it's stored as None Both tests also verify import_settings remains JSON-serializable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use datetime.timezone.utc instead of django.utils.timezone.utc which doesn't exist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
paulOsinski
approved these changes
Mar 26, 2026
blakeaowens
approved these changes
Mar 26, 2026
paulOsinski
approved these changes
Mar 27, 2026
Jino-T
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the import settings logic in the
update_import_historymethod ofbase_importer.py. The change ensures that thescan_dateis included in the import settings only if thescan_date_overrideflag is set; otherwise, it is set toNone.dojo/importers/base_importer.py: Modifiedupdate_import_historyto conditionally setimport_settings["scan_date"]based on thescan_date_overrideflag.