Refactor zip handling with safe_open_zip and safe_read_all_zip#14408
Merged
Refactor zip handling with safe_open_zip and safe_read_all_zip#14408
Conversation
Member
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
Could we use https://github.com/barseghyanartur/safezip instead?
blakeaowens
approved these changes
Mar 1, 2026
Contributor
FWIW, I kinda like not having YAD - yet another dependency |
rossops
approved these changes
Mar 2, 2026
Contributor
Author
Yeah agreed |
valentijnscholten
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate zip file handling by introducing
safe_open_zipandsafe_read_all_zipfunctions. Update existing importers to utilize these new functions for safer zip file operations.