fix: dedupe management command FieldError with only("id") and select_related#14350
Merged
Maffooch merged 2 commits intoDefectDojo:bugfixfrom Feb 23, 2026
Merged
Conversation
Using findings.only("id") while select_related traversal was still
active on the queryset caused a FieldError. Clear both select_related
and prefetch_related before calling only("id") so the async dispatch
path works regardless of how the queryset was constructed.
Also switch --dedupe_batch_mode from store_true to BooleanOptionalAction
so the flag can be explicitly disabled with --no-dedupe_batch_mode.
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
Maffooch
approved these changes
Feb 19, 2026
valentijnscholten
changed the title
blakeaowens
approved these changes
Feb 23, 2026
rossops
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FieldErrorin async dedupe path:findings.only("id")raised aFieldErrorwhenselect_relatedtraversal was still active on the queryset. Clearing bothselect_related(None)andprefetch_related(None)before callingonly("id")resolves this, making the async dispatch path work regardless of how the queryset was originally constructed.--dedupe_batch_modeflag: Changed fromaction="store_true"toaction=argparse.BooleanOptionalActionso the flag can be explicitly disabled with--no-dedupe_batch_mode(previously it could only be enabled, not disabled at the CLI).