Skip to content

chore(lint): apply no-unnecessary-type-assertion fixes from typescript-eslint 8.59#50

Merged
sjsyrek merged 1 commit intomainfrom
fix/lint-cleanup-no-unnecessary-type-assertion
Apr 27, 2026
Merged

chore(lint): apply no-unnecessary-type-assertion fixes from typescript-eslint 8.59#50
sjsyrek merged 1 commit intomainfrom
fix/lint-cleanup-no-unnecessary-type-assertion

Conversation

@sjsyrek
Copy link
Copy Markdown
Contributor

@sjsyrek sjsyrek commented Apr 27, 2026

Summary

typescript-eslint 8.59 (dependabot PR #38) tightened the `no-unnecessary-type-assertion` rule, surfacing 197 stale type assertions across src/ and tests/. This PR applies the auto-fixes ahead of #38 so its CI can go green on rebase.

Changes Made

  • Auto-applied `npm run lint:fix` — removed unnecessary `as` assertions across 44 files (197 total)
  • Manually fixed 3 test-file unused-import errors (TS6133) that surfaced after assertions were removed:
    • `tests/unit/glossary-command.test.ts`: drop unused `Language` import
    • `tests/unit/cli-translate-workflow.test.ts`: drop unused `Language` import
    • `tests/unit/sync/sync-command.test.ts`: drop unused `CliSyncOptions` import

Verification

Locally on commit cc88078:

  • ✅ `npm run lint` — clean
  • ✅ `npm run type-check` — clean
  • ✅ `npm test` — 5490/5490 pass
  • ✅ `npm run build` — clean
  • ✅ Example workflows (15, 30, 32, 35, 13) — all exit 0

Backward Compatibility

Maintained: No runtime behavior change. Pure type-system / lint cleanup. Type assertions removed were verifiably unnecessary (assert against the same inferred type).

Size: Small ✓

Mechanical refactor; large file count, tiny per-file diff (1–2 lines each).

🤖 Generated with Claude Code

…t-eslint 8.59

The typescript-eslint 8.59 release tightened the no-unnecessary-type-assertion
rule, surfacing 197 stale type assertions across src/ and tests/. Auto-fixed via
`npm run lint:fix`, plus 3 unused-import cleanups in test files that became
TS6133 errors after the assertions were removed:

- tests/unit/glossary-command.test.ts: drop unused Language import
- tests/unit/cli-translate-workflow.test.ts: drop unused Language import
- tests/unit/sync/sync-command.test.ts: drop unused CliSyncOptions import

Verified: lint clean, type-check clean, full test suite passes (5490/5490),
build succeeds, all 5 example workflows exit 0.

Unblocks dependabot PR #38 (typescript-eslint 8.58 → 8.59).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@sjsyrek sjsyrek merged commit 2bcee11 into main Apr 27, 2026
3 checks passed
@sjsyrek sjsyrek deleted the fix/lint-cleanup-no-unnecessary-type-assertion branch April 27, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant