Repository navigation
Check event title quality and require explicit topic review - #401
Open
alexeygrigorev wants to merge 2 commits into
Open
alexeygrigorev wants to merge 2 commits into
alexeygrigorev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event titles can currently be saved and treated as approved without checking casing, whether they name a topic, or whether the episode/Card/hold copies agree.
Add
dataops event title-checkfor existing events or a proposed title, anddataops event approve-titleto record an operator review of the exact title. Deterministic checks explain Title Case, draft/TBD and guest-only placeholders; breadth uses an explicit meaningful/broad/consistent checklist with the owner's narrow-topic example as a warning. Approval requires a review note, all three confirmations, matching stored copies and the current Card version. Changed titles invalidate approval. Document and public copies are explicitly included in the operator's consistency review; the checker never changes or publishes them.Save responses for Cards, episodes and holds expose actionable diagnostics, which the CLI also prints. Title-dependent Tasks can require the review through
validation.titleQuality: "topic-approval"or"publication". Calendar approval remains the scheduling action, so first-contact invitations and calendar acceptance receive no new topic-preview gate. No templates, SOPs, existing event titles or external services are changed by the check/review actions.A separate focused CI commit reuses the agreed fix from PR #400: select the direct Ubuntu archive before the unchanged Playwright dependency installation. The previous exact-head browser run failed before tests because the runner's Azure mirror could not resolve. Browser assertions and test steps are unchanged.
Validation: backend typecheck; targeted event title, lifecycle service, podcast episode and calendar hold tests (35 unique tests); CLI title-check/review tests. Covers all event types, spelling exceptions, drafts, review CAS/staleness, confirmed title-copy drift, save diagnostics and configured Task completion.