Skip to content

Check event title quality and require explicit topic review - #401

Open
alexeygrigorev wants to merge 2 commits into
mainfrom
t2043u-event-title-validation
Open

alexeygrigorev wants to merge 2 commits into
mainfrom
t2043u-event-title-validation

Conversation

@alexeygrigorev

@alexeygrigorev alexeygrigorev commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Event titles can currently be saved and treated as approved without checking casing, whether they name a topic, or whether the episode/Card/hold copies agree.

Add dataops event title-check for existing events or a proposed title, and dataops event approve-title to record an operator review of the exact title. Deterministic checks explain Title Case, draft/TBD and guest-only placeholders; breadth uses an explicit meaningful/broad/consistent checklist with the owner's narrow-topic example as a warning. Approval requires a review note, all three confirmations, matching stored copies and the current Card version. Changed titles invalidate approval. Document and public copies are explicitly included in the operator's consistency review; the checker never changes or publishes them.

Save responses for Cards, episodes and holds expose actionable diagnostics, which the CLI also prints. Title-dependent Tasks can require the review through validation.titleQuality: "topic-approval" or "publication". Calendar approval remains the scheduling action, so first-contact invitations and calendar acceptance receive no new topic-preview gate. No templates, SOPs, existing event titles or external services are changed by the check/review actions.

A separate focused CI commit reuses the agreed fix from PR #400: select the direct Ubuntu archive before the unchanged Playwright dependency installation. The previous exact-head browser run failed before tests because the runner's Azure mirror could not resolve. Browser assertions and test steps are unchanged.

Validation: backend typecheck; targeted event title, lifecycle service, podcast episode and calendar hold tests (35 unique tests); CLI title-check/review tests. Covers all event types, spelling exceptions, drafts, review CAS/staleness, confirmed title-copy drift, save diagnostics and configured Task completion.

alexeygrigorev added a commit that referenced this pull request Nov 11, 2026
…etries

A single runner apt mirror / DNS outage (Temporary failure resolving
archive.ubuntu.com, then no installation candidate) failed the job on
PR #400 and #401. Only the install step is retried; the E2E run stays a
single invocation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant