Skip to content

style(java): apply configured Java formatting [PROF-16537] - #957

Draft
kaahos wants to merge 1 commit into
paul.fournillon/fix-prof-16537-spotlessfrom
paul.fournillon/prof-16537-java-formatting
Draft

kaahos wants to merge 1 commit into
paul.fournillon/fix-prof-16537-spotlessfrom
paul.fournillon/prof-16537-java-formatting

Conversation

@kaahos

@kaahos kaahos commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?:
Apply the configured Google Java Format 1.30.0 output to 214 Java files across five modules. This is the second draft in the PROF-16537 stack, based on #955 rather than main.

Motivation:
The Java formatting gate restored by #955 rejects the existing source layout. Separating the migration lets reviewers inspect the small build repair without the formatting diff. This PR changes no formatting scope, exclusions or checks.

Additional Notes:

How to test the change?:
Validation covers the exact formatting commit on macOS arm64 with build JDKs 21.0.12 and 25.0.4.1. The separately reviewed stacked range retains those same source bytes.

  • passed: full root spotlessCheck --rerun-tasks --no-build-cache --max-workers=2 through ./.claude/commands/build-and-summarize on both JDKs, without file scoping or extra exclusions.
  • passed: all nine convention tests on each JDK, including real Java 8 compilation and class-file version 52.
  • passed: nine affected JavaCompile tasks on each build JDK. The demo retains its configured JDK 21 compiler in both runs.
  • passed: executed source-quality, copyright, CLAUDE, knowledgebase and whitespace checks. ELF signal-reachability checking is unavailable on macOS.
  • passed: independent 214/214 formatter/header reconstruction and unchanged literal-token lists, plus independent review of this exact stacked range.
  • inconclusive: current-main integration and CI for this newly stacked PR. Local or prior combined-PR results do not establish their success. No profiler/native runtime or sanitizer suite was run for this mechanical change.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a security review (run the dd:platform-security-review
    skill, or file a request via the PSEC review form).
    bewaire also runs automatically on every PR.
  • This PR doesn't touch any of that.
  • JIRA: PROF-16537

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

Your PR has warnings. Please review the issues below.

🚦 12 Pipeline jobs failed

DDCI - DataDog/java-profiler | renaissance-benchmarks: [naive-bayes, 25] — 🔄 Retry may pass, looks flaky

View more details · View in DDCI

DDCI - DataDog/java-profiler | renaissance-benchmarks: [akka-uct, 21]

View more details · View in DDCI

DDCI - DataDog/java-profiler | renaissance-benchmarks: [akka-uct, 25]

View more details · View in DDCI

View all 12 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eb06bd3 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Scan-Build Report

User:runner@runnervmwuk1x
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 all
Clang Version:Ubuntu clang version 21.1.8 (6ubuntu1)
Date:Mon Nov 9 14:05:49 2026

Bug Summary

Bug TypeQuantityDisplay?
All Bugs2
Logic error
Dereference of null pointer1
Unused code
Dead initialization1

Filter Results by File

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Unused codeDead initializationreferenceChains.cppapplyOomRamp4971
Logic errorDereference of null pointerperfEvents_linux.cppunregisterThread72026

@dd-octo-sts

dd-octo-sts Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #42631022125 | Commit: 63723e2 | Duration: 21m 34s (longest job)

✅ All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - ✅ - -
8-ibm - ✅ - -
8-j9 ✅ ✅ - -
8-librca - - ✅ ✅
8-orcl - ✅ - -
11 - ✅ - -
11-j9 ✅ ✅ - -
11-librca - - ✅ ✅
17 ✅ ✅ - -
17-graal ✅ ✅ - -
17-j9 ✅ ✅ - -
17-librca - - ✅ ✅
21 ✅ ✅ - -
21-graal ✅ ✅ - -
21-librca - - ✅ ✅
25 ✅ ✅ - -
25-graal ✅ ✅ - -
25-librca - - ✅ ✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-11-09 14:29:28 UTC

@kaahos

kaahos commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T17:12:07.734259Z eb06bd3 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: eb06bd345f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kaahos kaahos added test:release Run CI tests with release configuration test:asan Run CI tests with AddressSanitizer configuration test:tsan Run CI tests with ThreadSanitizer configuration test:fuzz test:reliability labels Nov 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:asan Run CI tests with AddressSanitizer configuration test:fuzz test:release Run CI tests with release configuration test:reliability test:tsan Run CI tests with ThreadSanitizer configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant