fix #5479: navigate back to correct item path after deleting custom URL

[guillermo-escire]

References

Fixes #5479

Description

After deleting a custom URL (dspace.customurl) from an item via Administer, the "Back" button now correctly navigates to the item's UUID-based path instead of the deleted custom URL.

Instructions for Reviewers

List of changes in this PR:

• edit-item-page.component.ts: Updated getItemPage() to extract the UUID directly from the current edit URL instead of relying on item metadata, avoiding navigation to a potentially deleted custom URL.
• item-page.resolver.ts: Added a check to prevent the resolver from redirecting to the custom URL when navigating back from an edit/administer page.
• Updated specs for both files accordingly.

Steps to test:

1. Go to an item page that has dspace.customurl set
2. Click the three-dot menu → Administer
3. In the Metadata tab, delete the dspace.customurl field and click Save
4. Click Back
5. Verify that it navigates to the correct item page via UUID (not a 404)
6. Refresh the page and verify it stays on the correct item page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[github-actions]

Hi @guillermo-escire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[lgeggleston]

Hi! I've tested this approach and looks like it fixes the main problem ✔️ the Back button always returns to the functional UUID page, no 404s, and clicking on the item page from elsewhere still takes you to the current custom url.

However, I'm not sure about the approach here to always take the user to the UUID page. With this change, going "Back" from the Edit or Administer page will always mean going back to UUID url instead of current custom URL, which could also be confusing.

When I edit or delete dspace.customurl in Administer metadata and Save, it does show the new auto-generated dspace.customurl immediately. So before moving ahead with this solution, I want to check - do you have any thoughts on why there's a mismatch between the updated customurl and the one returned from getItemPageRoute, and if it would be possible to resolve that instead of replacing with uuid?
Thanks for your work on this!

[guillermo-escire]

Hi @lgeggleston, thanks for the feedback!
The alternative would be to make itemRD$ reactive (removing getFirstCompletedRemoteData()) and invalidate the item cache after the metadata save. However, this touches dso-edit-metadata.component.ts which is a shared component used beyond items, increasing the risk of regressions.

The UUID approach is intentionally conservative, it guarantees no 404s in all cases. If the team prefers the reactive approach, we're happy to explore it in a follow-up PR.

[lgeggleston]

Hi @guillermo-escire, I'm sorry for the delay! Thanks for adding details about the alternative. Since this is a non-urgent bug fix and there's a possibility of confusion if we merge as-is, I think it may be best if we pause to gather additional developer opinions before moving forward with this or the itemRD$ reactivity path.