Skip to content

feat: removed python2 support#266

Merged
fstagni merged 2 commits intoDIRACGrid:develfrom
fstagni:removePy2
Oct 22, 2025
Merged

feat: removed python2 support#266
fstagni merged 2 commits intoDIRACGrid:develfrom
fstagni:removePy2

Conversation

@fstagni
Copy link
Copy Markdown
Contributor

@fstagni fstagni commented Sep 22, 2025

closes #263
closes #254

@fstagni fstagni force-pushed the removePy2 branch 9 times, most recently from 3b1db6e to 807db73 Compare September 22, 2025 10:41
@fstagni fstagni marked this pull request as ready for review September 26, 2025 14:09
Comment thread Pilot/tests/Test_Pilot.py Outdated
Comment thread Pilot/pilotTools.py Outdated
@aldbr
Copy link
Copy Markdown
Contributor

aldbr commented Oct 14, 2025

Oops, I see some test failures in the integration tests in your branch, are they expected?

@fstagni
Copy link
Copy Markdown
Contributor Author

fstagni commented Oct 14, 2025

Oops, I see some test failures in the integration tests in your branch, are they expected?

Yes I see those too, thank you for checking. The failures are there because the DIRAC certification setup is somehow broken. I did not yet look into that.

Comment thread Untitled Outdated
@fstagni fstagni merged commit 6ba51f7 into DIRACGrid:devel Oct 22, 2025
8 checks passed
@chrisburr
Copy link
Copy Markdown
Member

Why was this merged before removing the python 2 pilot tests from DIRAC?

Also 264587c is broken. The commit message talks about absolute imports when it's using relative ones and relative ones don't make sense in the way the pilotwrapper works.

@fstagni
Copy link
Copy Markdown
Contributor Author

fstagni commented Oct 24, 2025

Why was this merged before removing the python 2 pilot tests from DIRAC?

Also 264587c is broken. The commit message talks about absolute imports when it's using relative ones and relative ones don't make sense in the way the pilotwrapper works.

Indeed, it was clearly not tested enough, yesterday I was trying to find an easy way out but failed to do it quickly. So, you did well to revert it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python2.7 in CI not supported anymore Integrations test not testing python2

3 participants