Fix "combine" breaking dye mixes#1596
Merged
Merged
Conversation
There was a bug where using combine with mixed dyes would revert the mix to one of its component parts. Ex: You have 2 stacks of 2 Dye A, 3 stacks of 1 Dye B, and 1 stack of 3 of the mix Dye AB Expected behavior: use combine, you end up with 1 stack of 4 Dye A, 1 stack of 3 Dye B, and 1 stack of 3 Dye AB Actual behavior: use combine, you end up with 1 stack of **7** Dye A, 1 stack of 3 Dye B, and no Dye AB (because it combined AB with A)
Turns out that dye mixing does not like there being multiple units and/or stacks in a bag and it bugs out - removing dyes altogether for now
ab9rf
requested changes
Jul 11, 2026
ab9rf
left a comment
ab9rf
left a comment
Member
There was a problem hiding this comment.
This is a stopgap measure. the issue is that we really need to check the fields added in the dye update, but combine was never updated to do this.
That said, worth doing. No behavior is better than buggy behavior.
Needs changelog, will approve once changelog is added.
Contributor
Author
|
Thanks! I wasn't sure I'm talented enough to dig through fixing it to work properly with dyes, but at least this way no one will have whole stacks of dye effectively disappearing on them! |
ab9rf
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug where using combine with mixed dyes would revert the mix to one of its component parts.
Ex: You have 2 stacks of 2 Dye A, 3 stacks of 1 Dye B, and 1 stack of 3 of the mix Dye AB
Expected behavior: use combine, you end up with 1 stack of 4 Dye A, 1 stack of 3 Dye B, and 1 stack of 3 Dye AB
Actual behavior: use combine, you end up with 1 stack of 7 Dye A, 1 stack of 3 Dye B, and no Dye AB (because it combined AB with A)