Skip to content

fix: declared license texts as such, not as license name#694

Merged
jkowalleck merged 14 commits into
mainfrom
fix/declared-license-texts
Mar 15, 2024
Merged

fix: declared license texts as such, not as license name#694
jkowalleck merged 14 commits into
mainfrom
fix/declared-license-texts

Conversation

@jkowalleck
Copy link
Copy Markdown
Member

fixes #692

@jkowalleck jkowalleck added the bug Something isn't working label Mar 14, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the fix/declared-license-texts branch from e0b7dae to a43996c Compare March 14, 2024 17:11
Comment thread cyclonedx_py/_internal/utils/pep621.py Outdated
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Mar 15, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 97.06% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f27170e) 1009 975 96.63%
Head commit (c28d8d1) 1023 (+14) 988 (+13) 96.58% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#694) 34 33 97.06%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jkowalleck jkowalleck marked this pull request as ready for review March 15, 2024 11:37
@jkowalleck jkowalleck requested a review from a team as a code owner March 15, 2024 11:37
@jkowalleck jkowalleck changed the title fix: declared license texts as such, not as license name. fix: declared license texts as such, not as license name Mar 15, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit ec7ab3e into main Mar 15, 2024
@jkowalleck jkowalleck deleted the fix/declared-license-texts branch March 15, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

declared non-SPDX license shoud result in text attachment

1 participant