Skip to content

Start a computer that is off when a person opens its screen - #1595

Open
davidmckayv wants to merge 1 commit into
mainfrom
screen-starts-computer
Open

davidmckayv wants to merge 1 commit into
mainfrom
screen-starts-computer

Conversation

@davidmckayv

Copy link
Copy Markdown
Contributor

What was wrong

Nothing the Screen tab reads starts a computer. A computer that was off stayed off however long a person looked at its screen, and the only way to see the Bot's browser was to ask the Bot to do something.

What changes

  • The screen beside a conversation says it was opened (POST /api/computers/:botId/wake) when it finds the computer off, and reads "Starting Sales's computer. The first start takes about a minute." while it comes up.
  • It asks once, for what the screen found when it opened. A computer that goes off later, in front of a screen somebody left open, stays off. A card in a turn never asks: the Bot's action starts that computer.
  • When the call is not answered, the screen says the computer is off, as it did before.
  • Words for two audit events on the Audit and Activity pages: computer.suspended ("Turn off an idle computer", decision "Turned off while idle") and computer.resumed ("Start a computer again", decision "Started again").

No new copy on the screen: both sentences are the ones already there.

Tests

app/tests/computer-calm-start.test.tsx:

  • opening the screen on a computer that is off asks for it once and reads "Starting", never "is off" (fails without the change);
  • a card in a turn does not ask;
  • a computer that goes off while the screen is open is not asked for again.

Checked in a browser

Screenshots of the Screen tab in Chromium and WebKit to follow in a comment.

Nothing the Screen tab reads starts a computer, so one that was off stayed
off however long a person looked at it, and the only way to see the Bot's
browser was to ask the Bot to do something.

The screen beside a conversation now says it was opened
(POST /api/computers/:botId/wake) when it finds the computer off, and reads
"Starting ... computer" while it comes up. Once, for what the screen found
when it opened: a computer that goes off later in front of a screen left
open stays off, and a card in a turn never asks, because the Bot's action
starts that one. When the call is not answered the screen says the computer
is off, as before.

Also words for two audit events, a computer turned off for being idle and
started again, on the Audit and Activity pages.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant