Repository navigation
End a turn whose run went quiet once the runtime says it has no run, or can't say - #1593
Open
davidmckayv wants to merge 2 commits into
Open
davidmckayv wants to merge 2 commits into
davidmckayv wants to merge 2 commits into
Conversation
…or can't say With the service that carries a conversation's events stalled mid-run, the reply stopped half written and its step said "Running", with Stop up, for good: the server had given the run up, and nothing could tell the browser. After 45 seconds with nothing arriving from a run the runtime is asked whether the conversation still has one going, and again every 45 seconds while it says yes. When it says no, or cannot answer, the turn ends with a sentence saying so and what was saved is read back.
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 14, 2026 04:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A turn whose run has gone quiet now ends when the runtime says the conversation has no run going, or can't say. Before, it waited for good.
Found in testing, with the service that carries a conversation's events stalled mid-run:
The check (
app/src/lib/copilot/quiet-run.ts, used inchannel-chat.tsx):Evidence
Tests (
app/tests/quiet-run.test.ts): what each answer from the runtime means, including one that never comes; a quiet run kept while the runtime says it is going and ended when it says it is not; a run that keeps speaking never asked about; nothing asked between a turn's runs; a late answer not taken.Real product, with the service frozen six seconds into a run:
Ordinary turns are unchanged: a short answer, and a turn that stops for an approval and carries on, both finished as before.