Repository navigation
Say what came of an approved action when its conversation could not be carried on - #1592
Open
davidmckayv wants to merge 2 commits into
Open
davidmckayv wants to merge 2 commits into
davidmckayv wants to merge 2 commits into
Conversation
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 14, 2026 04:25
…e carried on An allowed Slack post went out, the conversation could not be carried on after it, and its step said "Send message…" for good with nothing to say the post was made. The step now draws the outcome its request holds: whether the action was done, that nothing followed it, and to send a message to continue. The next message sends the Bot the answer the conversation never received in place of "no result came back", so it does not post again.
davidmckayv
force-pushed
the
approval-left
branch
from
November 14, 2026 04:59
99d6859 to
84a2b98
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A step whose conversation could not be carried on after the person decided it now says what came of it.
Found in testing. A person allowed a Slack post, the post went out, and the conversation could not be carried on afterwards. The step said "Send message…" for good, with nothing to say the post was made. The next message then told the Bot "no result came back" for a call that had run, which invites it to post again.
left: whether the action was done, the sentence that says so, and the answer the conversation never received.leftAnswers,repairUnansweredToolCalls).Evidence
Tests (
app/tests/approval-left-not-carried-on.test.tsx): the sentence under a step, beside a folded group, as an alert when the action was not done, and the next message's history carrying the kept answer. All four fail on main.Real product, Chromium and WebKit headless, light and dark, with the thread lock refused after the person allowed a Slack post: the post was made once, the step said "Done: send message on Slack. …" about 50 seconds later, and after recovery the Bot answered "Yes, 'the deck is ready' was posted in #launch." without posting again.