Repository navigation
Clear the last run's shutdown notice once Start runs - #1589
Open
davidmckayv wants to merge 1 commit into
Open
davidmckayv wants to merge 1 commit into
davidmckayv wants to merge 1 commit into
Conversation
After OpenBot quit while its engine machine was stopped, the next launch showed "That didn't finish: OpenBot had trouble shutting down last time." over the stopped card, and the card stayed through Start and every Retry. When that Start stopped too, with the engine down, the old notice read as the reason. The notice the window reads at launch is about the last run, so it now goes as soon as a Start runs. A Start that then stops says why in its own row, and a failure of the new Start is shown as before.
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 14, 2026 03:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
After OpenBot quit while its engine machine was stopped, the next launch showed "That didn't finish: OpenBot had trouble shutting down last time." over the "OpenBot is stopped" card. The card stayed through Start and through every Retry. When that Start stopped as well (the engine was down, "Getting OpenBot ready" failed with "The software OpenBot runs on isn't running. Retry to start it."), the old notice read as the reason this run stopped.
The cause: the setup window keeps what
last_failurereturned at launch as its recovery failure, and cleared it only when a Start succeeded, on Stop, or on a provider change. A Start that stopped in the local sequence never reached any of those.The fix
The notice read at launch is about the last run, so it goes as soon as a Start runs. Only that notice is cleared: a failure of the new Start still shows, in its row and in the card, as before.
Tests
the last shutdown's notice goes once Start runs, and a Start that stops says only why: launch with the shutdown notice, press Start with the engine down, then Retry once it answers. Failed before the fix (the notice was still on screen after Start stopped), passes after.bun test desktop/src(416 pass),bun run --cwd desktop typecheck,bun run format:check,bun run lint.