Repository navigation
One color per Bot, a maximized window that reopens maximized, and plain installer lines - #1566
Merged
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 13, 2026 18:08
davidmckayv
force-pushed
the
fix/bot-orb-window-installer-lines
branch
from
November 13, 2026 19:48
1462200 to
52f6622
Compare
…in installer lines A Bot's orb is one color everywhere. Its palette was drawn two ways: still at avatar sizes, and as AgentOrb's mesh when larger, where the palette's violet lay across the top. The Personal Assistant was green in the sidebar and blue, teal and pink at the top of its page and its conversation. The live orb now draws the still orb's sphere, with its sweep turning, and keeps the palette's colors in every state. A real-browser test compares the color of each Bot's orb in the sidebar, on its page and at the top of its conversation, for all eight palettes in both themes. A window maximized when OpenBot was quit from the tray reopens maximized. Windows hangs a maximized window's frame past the screen by its resize border, at -8,-8 on a 1920 by 1080 screen, and launch read that as off every screen and moved it, which un-maximized it to 1000 by 800. A maximized or full-screen window is now left as the system placed it, neither moved nor resized, which also keeps a zoomed Mac window zoomed. A window that really is off every screen still comes onto the primary one. The Windows installer's status line says plain lines only. The Install section's "Output folder:", "Create folder:", "Extract:", "Created uninstaller:" and "Create shortcut:" lines, each with a path in the person's user folder, go to the details list, under "Copying OpenBot's files.", and a leftover WebView2 bootstrapper is deleted under the plain line.
FileFunc's GetSize says "Size:190 Kb Files:1 Folders:" on the status line and sets it back to both, so "Create shortcut: C:\Users\...\OpenBot.lnk" showed after it on the first live run. The uninstaller's size is read quietly instead, and the template test now follows a Goto and counts GetSize and Locate as status lines.
davidmckayv
force-pushed
the
fix/bot-orb-window-installer-lines
branch
from
November 13, 2026 21:39
52f6622 to
ae94fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs the Windows pass of merged work found.
A Bot's orb is one color everywhere. The Personal Assistant's orb was green in the sidebar, the Bots list and the command menu, and blue, teal and pink at the top of its page and of its conversation. Both came from the same palette (
orbPalette), drawn two ways: still at avatar sizes, and asAgentOrb's mesh when larger, where the palette's third stop, a violet in most palettes, lay across the top, and the idle state muted it. Now the live orb draws the still orb's sphere (.bot-orb-stilland.bot-orb-liveside by side instyles.css), with its sweep turning, and a Bot's orb keeps its palette in every state (trueColors). The onboarding pictures' Bot orbs and the OpenBot for Business orb, which say they are drawn as a Bot's, follow.OpenBot Desktop draws its app from the published server images it runs, so Desktop shows the one-color orb once those images include this commit; the web app has it on merge.
A maximized window reopens maximized. After tray Quit with the window maximized on Windows, it came back at 1000 by 800 in the middle of the screen, and the log said "put back off every screen; moved onto the primary one". The saved state was right (maximized, with its place before it was maximized). Windows hangs a maximized window's frame past the screen by its resize border, so its outer position is -8,-8 on a 1920 by 1080 screen and the top 8 pixels of its title bar are above the work area. Launch read that as off every screen and moved it, which un-maximized it; its height fit would have resized it too. A maximized or full-screen window is now left as the system placed it, which also keeps a zoomed Mac window zoomed. A window that really is off every screen still comes onto the primary one.
tauri-plugin-window-state(2.5.0, the current release) already saves and restores the state; it has no fallback onto the primary screen for a screen that is gone, so the launch fit stays ours and is fixed.The Windows installer's status line says plain lines only. The Install section's "Output folder:", "Create folder: C:\Users...\AppData\Local\OpenBot\cli-bundle...", "Extract: ...", "Created uninstaller:" and "Create shortcut:" lines go to the details list, under "Copying OpenBot's files.", as the old version's removal already does. A leftover WebView2 bootstrapper is deleted under the plain line. FileFunc's
GetSize, which Tauri uses to size the uninstaller, says "Size:190 Kb Files:1 Folders:" on the status line and switches it back on when it ends, so "Create shortcut: C:\Users...\OpenBot.lnk" showed after it on the first live run; the uninstaller's size is now read quietly andGetSizeskipped. (The WebView2 "Execute:" line was already fixed by #1544.)Tests, red before and green after
app/tests/bot-orb-one-color.test.tsx(real Chromium, in the CI browser job): the real sidebar row, Bot page header and conversation intro, all eight palettes, light and dark; each orb's mean color in OKLab. Before: 14 of 16 comparisons per theme apart, the Personal Assistant's hue turned 47°, the furthest 116°. After: every palette within 4.3 and 5°.The same test run in Playwright WebKit (headless) is red on main the same way and green on this branch.
a_maximized_window_reopens_maximized_where_the_system_put_it(Rust): Windows maximized geometry (-8,-8, 1936 by 1056 on 1920 by 1080), maximized on a second screen, zoomed on a MacBook, a window really off every screen, and the saved maximized place. Before: the maximized window was movedOnto(0,0).desktop/scripts/installer-update.test.ts: runs the Install section and the WebView2 download and install in order, trackingSetDetailsPrint, and fails on any NSIS instruction that would put a path on the status line. It follows aGotoand countsGetSizeandLocateas status lines. Before: 9 such lines in the Install section; on the first fix,GetSizeand the 2 shortcut calls after it, as the live run showed.