Repository navigation
Mac window on OpenBot's ground from the first frame, and no 2-minute pause on a fresh Windows install - #1562
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 13, 2026 14:52
davidmckayv
force-pushed
the
fix/desktop-first-paint-and-install-stall
branch
3 times, most recently
from
November 13, 2026 21:44
582be31 to
647160c
Compare
… CLI stop on a fresh install macOS built the main window with no background of its own, so before the setup page painted it showed the system's grey and then WKWebView's white. It is now built on the setup screens' ground in light or dark, as Windows already was, with the system's appearance read from AppKit when OpenBot has not said yet. The Windows installer's first step started PowerShell and WMI to stop the bundled CLI even when this installation had no cli-bundle folder, which held the Installing page still for about two minutes on a fresh box. It now runs only when that folder exists, so updates and reinstalls still stop it.
davidmckayv
force-pushed
the
fix/desktop-first-paint-and-install-stall
branch
from
November 13, 2026 21:58
647160c to
9158c83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a person saw
Why
OPENBOT_STOP_BUNDLED_CLI, feat(desktop): standalone OpenBot with local CopilotKit Intelligence, from the app alone #832 and Stop the bundled CLI from the 32-bit Windows installer before replacing node.exe #1071). It ran on every install, so on a fresh box it started PowerShell and a WMI process query to look under acli-bundlefolder that did not exist yet. That step is where the page sat for about two minutes, undernsExec::Exec, which prints no line and leaves the bar still.What changed
Mac first paint
#ededf5, dark#0d0b13, the same colours the title bar already takes on the setup page), through Tauri'sbackground_coloron the builder. On macOS that sets the window's background (NSWindow.backgroundColor) and, in wry 0.54.2 and later (this build has 0.57.1), turns off WKWebView's own white (drawsBackground) and sets the colour behind the page (underPageBackgroundColor), so the ground shows from the first frame until the page paints (wry 0.54.2 notes, Tauri builder).effectiveAppearance,bestMatch(from:)), as tao reads it for a window's theme. Before this it always said light off Windows.Windows install
$INSTDIR\cli-bundleexists (IfFileExists DIR\*.*, NSIS 4.9.4.10). Nothing can run from a folder that is not there, and Windows keeps a running program's file, so its folder, until it exits. An update or a reinstall over a bundled CLI has the folder and stops it exactly as before; a fresh install, or one without a bundled CLI, skips it. Same on uninstall.Tests
the_main_window_is_built_on_the_setup_ground_on_macos_and_windows(main.rs): the builder'sbackground_coloris set on macOS and Windows, beforebuild(), and its colours are the title bar's. Red with main's builder line (Windows only), green here.a_dark_mac_builds_the_window_on_the_dark_ground(first_paint.rs, macOS): Dark Aqua and Vibrant Dark read as dark, Aqua and Vibrant Light as light, with AppKit's own appearances.the_bundled_cli_stop_runs_only_when_there_is_a_cli_bundle_to_stop(recorder_install.rs): everything the stop runs sits inside thecli-bundlecheck, it is the folder the script searches, and the stop still runs on every install (after the old version is removed) and uninstall. Red with main's hooks.nsh, green here.To check before merge