Repository navigation
fix(desktop): treat a missing WSL default version as WSL 1 - #1554
Open
Ethereal49 wants to merge 1 commit into
Open
Ethereal49 wants to merge 1 commit into
Ethereal49 wants to merge 1 commit into
Conversation
Ethereal49
requested review from
MikeRyanDev,
davidmckayv,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 13, 2026 08:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #1550.
On a Windows machine that only has WSL 1, setup failed with:
The registry probe treated a missing
DefaultVersionvalue as WSL 2. Setup therefore skipped the WSL1 blocker and ranwsl.exe --version, which the legacy inbox binary does not understand. An absent value now returnsunset, and the parser maps it to WSL 1, so the existingWslOnescreen is reached with thewsl --set-default-version 2instructions before the unsupported command runs.Where it runs
Boundary and audit
Changelog
Added a line under
UnreleasedinCHANGELOG.md.Proof
cargo test an_unset_default_version— 2 passed.cargo test windows::tests— 50 passed.unsetprobe result and asserts theWslOneblocker is returned without invokingwsl.exe --version.AI disclosure: prepared with Codex; the tests above were run locally. Human review is welcome.