Repository navigation
Hold OpenBot back from the front while the browser sign-in is open - #1421
Merged
Merged
Conversation
On Windows F, "[front] the engine machine is prepared" brought OpenBot in front of the browser while the person typed their email to sign in. While the browser sign-in is open, bring_to_front holds back and logs "[front] held back: sign-in open in the browser"; when the sign-in ends, however it ends, OpenBot comes forward once, since the license agreement is the person's next step then (flashing the taskbar if Windows refuses).
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 10, 2026 15:41
davidmckayv
added a commit
that referenced
this pull request
Nov 10, 2026
… downloads kept Main's #1434 engine update path, #1435 stall timing, #1427, #1421, #1426, #1411, #1340, #1344 and #1345 are taken as they are. On top: - A download the running setup step waits on (the machine image, or the images the first screen started) restarts that step's stall clock while its bytes come in, as a moving CLI download does. Its progress goes out numbered like every other row, so the window's heartbeat counts it. - A Podman too old for OpenBot gets the installer #1434 runs over it from the first screen too. - On Welcome the download line holds the height of its tallest state, so the usage-data text under it no longer moves up when the download ends. A real-browser test holds that text still across every state. - The account step's new heading in the tests.
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Live on Windows F, while the person was on the browser's CopilotKit sign-in page typing their email, "[front] the engine machine is prepared" brought OpenBot in front of the browser and took the focus mid sign-in. With #1417,
SetForegroundWindowsucceeds there, so setup's own moments steal the focus.Change
sign_in_to_copilotkit, from the moment the Account step starts it until it ends),bring_to_frontholds back and logs[front] held back: sign-in open in the browser (<why>). That covers the engine machine being prepared, Docker Desktop answering, the engine no longer needing another app's window, and the page's own requests. None of them is the person's next step while they are in the browser.Test
nothing_comes_forward_while_the_browser_sign_in_is_open_and_once_when_it_endschecks:bring_to_frontchecks the hold before anything else, and the sign-in runs inside it.It runs in its own process, since the hold is process-wide. Without the hold in
bring_to_frontand the sign-in, it fails; with them, it passes.