Skip to content

Changed HTTP status codes to http.StatusCode instead of the actual numbers#85

Merged
tallen42 merged 1 commit intodevfrom
http-status-names
Feb 23, 2026
Merged

Changed HTTP status codes to http.StatusCode instead of the actual numbers#85
tallen42 merged 1 commit intodevfrom
http-status-names

Conversation

@pikachu0542
Copy link
Copy Markdown
Member

What

Used http.StatusCode for all the status codes instead of specifying the actual number

Why

Makes it easier to identify what status is being returned. Also good for if any status code numbers get changed (not that i think this would happen, but its a theoretical benefit)

Test Plan

  • Verify all numeric status codes are replaced with the equivalent http.StatusCode
  • Ensure that all instances where I changed a 500 to something else actually makes sense in context

Env Vars

No

Checklist

  • Tested all changes locally

…ged some 500s to 400s where appropriate to indicate user error
@pikachu0542 pikachu0542 self-assigned this Feb 23, 2026
@pikachu0542 pikachu0542 added enhancement New feature or request go Pull requests that update go code labels Feb 23, 2026
Copy link
Copy Markdown
Contributor

@tallen42 tallen42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tallen42 tallen42 merged commit 8189e8a into dev Feb 23, 2026
1 check passed
tallen42 pushed a commit that referenced this pull request Feb 23, 2026
…ged some 500s to 400s where appropriate to indicate user error (#85)
pikachu0542 added a commit that referenced this pull request Apr 8, 2026
* Changed all status codes to the http.StatusCode equivalent. Also changed some 500s to 400s where appropriate to indicate user error (#85)

* Started working on navbar

* More progress

* working theme selector

* Eboard vote link appears on all pages

* Started working on navbar

* More progress

* working theme selector

* Rebase with dev

* Finished rebasing with dev

* Added favicon import

* Misc other stuff, navbar is responsive now

* larger nav title

* Quorum text input, create page basically done

* Finished poll creation page

* Ranked choice poll page is done

* Actually use the hidden template

* changed icon

* Fixed vote count on eboard votes

* Added display of total votes submitted to results

* small fixes

* fixed spacing between buttons for eboard vote on mobile

* poll title wrapping in a different place

* Changed underline to bold

* Capitalize description placeholder text

---------

Co-authored-by: Noah Hanford <bigspaceships56@gmail.com>
pikachu0542 added a commit that referenced this pull request Apr 9, 2026
* Changed all status codes to the http.StatusCode equivalent. Also changed some 500s to 400s where appropriate to indicate user error (#85)

* Started working on navbar

* More progress

* working theme selector

* Eboard vote link appears on all pages

* Started working on navbar

* More progress

* working theme selector

* Rebase with dev

* Finished rebasing with dev

* Added favicon import

* Misc other stuff, navbar is responsive now

* larger nav title

* Quorum text input, create page basically done

* Finished poll creation page

* Ranked choice poll page is done

* Actually use the hidden template

* changed icon

* Fixed vote count on eboard votes

* Added display of total votes submitted to results

* small fixes

* fixed spacing between buttons for eboard vote on mobile

* poll title wrapping in a different place

* Changed underline to bold

* Capitalize description placeholder text

---------

Co-authored-by: Noah Hanford <bigspaceships56@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants