✨ Move selected lines up and down

[austincondiff]

Description

Users should be able to move lines up or down with ⇧ ⌘ [ and ] or by going to Editor > Move Line Up and Move Line Down.

Screenshots

[Bogdan-Belogurov]

@austincondiff Hello! Do you mind if I take this?

[0xWDG]

@austincondiff Hello! Do you mind if I take this?

I have assigned you :)

[Bogdan-Belogurov]

@0xWDG
Hello!
I've made the first prototype

Details

normal.mov

And I noticed a few problems:

1. If I select a line from the zero position, then in the editSelections method, the selection range includes that line, even if the selection is not actually visible in the UI. Is that the way it's meant to be?

Details

issue.mov

2. As I see from Xcode, during line up/down actions, the selected lines understand their scope and automatically add/remove additional indents. Can you please show me where to look to implement similar logic? 🙏🏿

[austincondiff]

First of all, great work so far! Maybe if the selection ends with a newline character, we exclude it. Would that work?

[Bogdan-Belogurov]

@austincondiff
Thanks! I'm not sure about the newline character because it allows you to draw the whole line in the UI, am I right?

From my perspective, it would be better to handle this case in the getHighlightedLines-> textLineForOffset method. What do you think?

[thecoolwinter]

I think you're right to keep the newline character, but it sounds like there might be something going funky with finding the lines being selected to move.

And I noticed a few problems:

1. If I select a line from the zero position, then in the editSelections method, the selection range includes that line, even if the selection is not actually visible in the UI. Is that the way it's meant to be?

What are you using to determine what lines are selected? The editSelections method just passes along any text selections active in the TextView, so that makes me think there's maybe something going on with whatever method is being used to find lines in the selected range.

2. As I see from Xcode, during line up/down actions, the selected lines understand their scope and automatically add/remove additional indents. Can you please show me where to look to implement similar logic? 🙏🏿

Right now we don't have any architecture for determining 'correct' indent levels. I may be building that out right now while developing the line folding gutter and I know tree-sitter has that capability, but we haven't had a need for it just yet.

[Bogdan-Belogurov]

@thecoolwinter Hello!

What are you using to determine what lines are selected?

I use getHighlightedLines method to determine what lines are selected

guard let lineIndexes = getHighlightedLines(for: selection.range) else { return }

Here I've selected starting at line 27 of the zero position

getHighlightedLines output:

[thecoolwinter]

Okay looking into that method you're right it's not returning what you'd expect. Technically the selection contains the second line (line 27 in your screenshot), but that method shouldn't be returning both those lines. That's actually causing another bug with the indent lines functionality with the same issue you found. I'll have a patch ready in a moment for that method that should make it function as expected.