Skip to content

✨ Setting to Wrap lines to editor width #868

Closed

Description

@austincondiff

Is your feature request related to a problem? Please describe.

This issue should be worked on with the above issue.

Describe the solution you'd like

Add a setting under Text Editing that allows a user to enable or disable line wrapping within the editor.

Indented lines should wrap to set width.

Additional context

Screenshot 2022-12-17 at 4 21 05 PM

Activity

  1. ben-p-commits commented on Jan 3, 2023

    @ben-p-commits
    Contributor

    @austincondiff - I'd like to nab this one.

  2. ben-p-commits commented on Jan 3, 2023

    @ben-p-commits
    Contributor

    Interesting- I couldn't get horizontal text wrapping to work until I commented out this line:

    STTextViewController.swift:86
    image

    It appears to have regressed the default functionality provided by STTextView's widthTracksTextView property.

  3. ben-p-commits commented on Jan 3, 2023

    @ben-p-commits
    Contributor

    Per Khan's comment on discord,

    image

    Will see if I wrap this work before he wraps his on adopting TK2.

  4. austincondiff commented on Jan 3, 2023

    @austincondiff
    CollaboratorAuthor

    Thank you for documenting this here @ben-p-commits!

  5. ben-p-commits commented on Jan 4, 2023

    @ben-p-commits
    Contributor

    @austincondiff - After doing some digging, it appears that implementing functionality needed for the wrapped line indentation stepper control...

    ...as implied by this screencap:
    image

    would require some pretty sensitive changes to STTextView. Have we run into this sort of problem yet?

    I can get this enhancement working with the toggle option for wrapping, but implementing the stepper setting and associated behavior in the textview itself may be better split out as a separate enhancement imo.

  6. austincondiff commented on Jan 4, 2023

    @austincondiff
    CollaboratorAuthor

    That is fine, we may need to create an issue in CodeEditTextView for that then in response to this issue.

  7. ben-p-commits commented on Jan 4, 2023

    @ben-p-commits
    Contributor

    I'll add one. Thanks.

  8. ben-p-commits commented on Jan 4, 2023

    @ben-p-commits
    Contributor
  9. ben-p-commits commented on Jan 13, 2023

    @ben-p-commits
    Contributor

    @austincondiff - this has merged and should be good to close. As mentioned before- the indenting behavior is covered in a separate issue in CodeEditTextView

  10. moved this from 🆕 New to 🏁 Complete in CodeEdit Projecton Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions