Skip to content

🐞 Close tab works when the 'Open Quickly' or 'Quick Actions' modal is open #1796

Description

@plbstl

Description

When the 'Open Quickly' or 'Quick Actions' modal is open, cmd+w still works and the TabBar's selected tab background does not dim.

cmd+w also closes the 'Open Quickly' and 'Quick Actions' modals.

To Reproduce

  1. Open a folder containing multiple files in CodeEdit.
  2. Double click on a few files to open them in the editor view.
  3. Use cmd shift o to show the 'Open Quickly' modal.
    • Or cmd shift p to show the 'Quick Actions' modal.
  4. Notice that the TabBar's selected tab is not dimmed.
  5. Use cmd w to close the selected tab.

Expected Behavior

When the 'Open Quickly' or 'Quick Actions' modal is open, close tab shortcut should not work.

cmd+w should not close the 'Open Quickly' or 'Quick Actions' modal

Version Information

CodeEdit: 0.1.0-dev (38)
macOS: 14.5
Xcode: 15.4

Additional Context

No response

Screenshots

CodeEdit:

codeedit.modal.close.tab.mov

Xcode:

xcode.modal.close.tab.mov

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions