Skip to content

ci: remove samply walltime profiler and pinned runner version #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 5 commits into from
Jun 22, 2026
+9 −8
Merged

ci: remove samply walltime profiler and pinned runner version #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b39055
Revert "wip: use latest runner to fix samply"
not-matthias Jun 22, 2026
c4ac426
ci: remove CODSPEED_WALLTIME_PROFILER samply env var
not-matthias Jun 22, 2026
4327254
ci: lower CodSpeed Benchmarks timeout to 15 minutes
not-matthias Jun 22, 2026
1a12a56
fix(ci): cache capstone prefix so install survives a cache hit
not-matthias Jun 22, 2026
e0e62db
fix(bench): drop stress-ng benchmarks
not-matthias Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/codspeed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
benchmarks:
runs-on: codspeed-macro
timeout-minutes: 30
timeout-minutes: 15
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -40,8 +40,14 @@ jobs:
uses: actions/cache@v4
id: valgrind-cache
with:
path: /tmp/valgrind-build
key: valgrind-${{ matrix.valgrind }}-${{ runner.os }}-${{ matrix.valgrind == 'local' && hashFiles('coregrind/**', 'include/**', 'VEX/**', 'cachegrind/**', 'callgrind/**', 'dhat/**', 'drd/**', 'helgrind/**', 'lackey/**', 'massif/**', 'memcheck/**', 'none/**', 'exp-bbv/**', 'auxprogs/**', '*.ac', '*.am', '*.in', 'autogen.sh', 'configure*') || 'build' }}
# `.capstone` is the cycle-estimation decoder prefix; its absolute path
# is baked into the Makefile's -I flags, so `make install` (which may
# recompile cycledecode.o) needs it present. It is built outside
# /tmp/valgrind-build, so cache it too or a cache hit breaks install.
path: |
/tmp/valgrind-build
.capstone
key: valgrind-${{ matrix.valgrind }}-${{ runner.os }}-v2-${{ matrix.valgrind == 'local' && hashFiles('coregrind/**', 'include/**', 'VEX/**', 'cachegrind/**', 'callgrind/**', 'dhat/**', 'drd/**', 'helgrind/**', 'lackey/**', 'massif/**', 'memcheck/**', 'none/**', 'exp-bbv/**', 'auxprogs/**', '*.ac', '*.am', '*.in', 'autogen.sh', 'configure*') || 'build' }}

# Build and install Valgrind
- name: Update apt-get cache
Expand Down Expand Up @@ -98,9 +104,6 @@ jobs:

- name: Run the benchmarks
uses: CodSpeedHQ/action@main
env:
CODSPEED_WALLTIME_PROFILER: samply
with:
mode: walltime
config: bench/codspeed.yml
runner-version: 4.17.7-alpha.1
2 changes: 0 additions & 2 deletions bench/generate_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
"testdata/take_strings-aarch64 varbinview_non_null",
"echo Hello, World!",
"python3 testdata/test.py",
"stress-ng --cpu 1 --cpu-ops 10",
"stress-ng --cpu 4 --cpu-ops 10",
]

# Callgrind configurations: (extra args, config name, requires_codspeed). The
Expand Down
Loading