Skip to content

fix: add marker windows stubs#9

Merged
not-matthias merged 1 commit into
mainfrom
cod-1430-instrument-hooks-marker-functions-not-exported-on-windows
Oct 3, 2025
Merged

fix: add marker windows stubs#9
not-matthias merged 1 commit into
mainfrom
cod-1430-instrument-hooks-marker-functions-not-exported-on-windows

Conversation

@not-matthias

@not-matthias not-matthias commented Oct 2, 2025

Copy link
Copy Markdown
Member
  • Fixed the return types in the header (zig exports it as u8)
  • Added the missing marker functions

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Windows stubs for marker/timestamp APIs and updates the example to demonstrate start/end benchmark markers around a function call.

  • Add instrument_hooks_current_timestamp and instrument_hooks_add_marker stubs on Windows.
  • Update example to record start/end timestamps around example_function and include an artificial expensive setup step.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
scripts/windows_stub.c Adds Windows stub implementations for timestamp and marker APIs.
example/main.c Demonstrates capturing timestamps and adding benchmark start/end markers; introduces helper functions for workload.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scripts/windows_stub.c Outdated
Comment thread example/main.c Outdated
Comment thread example/main.c Outdated
Comment thread example/main.c
Comment thread scripts/stub.c
@not-matthias not-matthias force-pushed the cod-1430-instrument-hooks-marker-functions-not-exported-on-windows branch from 04f524f to 9bf7cb4 Compare October 2, 2025 11:15
@not-matthias not-matthias requested a review from Copilot October 2, 2025 11:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread includes/core.h
Comment thread scripts/stub.c
Comment thread scripts/stub.c
@not-matthias not-matthias requested a review from art049 October 2, 2025 15:43
@not-matthias not-matthias force-pushed the cod-1430-instrument-hooks-marker-functions-not-exported-on-windows branch from 9bf7cb4 to 8ba9ba2 Compare October 3, 2025 12:25
@not-matthias not-matthias force-pushed the cod-1430-instrument-hooks-marker-functions-not-exported-on-windows branch from 8ba9ba2 to b1e401a Compare October 3, 2025 15:05
@not-matthias not-matthias merged commit b1e401a into main Oct 3, 2025
15 checks passed
@not-matthias not-matthias deleted the cod-1430-instrument-hooks-marker-functions-not-exported-on-windows branch October 3, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants