fix: add marker windows stubs#9
Merged
not-matthias merged 1 commit intoOct 3, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds Windows stubs for marker/timestamp APIs and updates the example to demonstrate start/end benchmark markers around a function call.
- Add instrument_hooks_current_timestamp and instrument_hooks_add_marker stubs on Windows.
- Update example to record start/end timestamps around example_function and include an artificial expensive setup step.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/windows_stub.c | Adds Windows stub implementations for timestamp and marker APIs. |
| example/main.c | Demonstrates capturing timestamps and adding benchmark start/end markers; introduces helper functions for workload. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
04f524f to
9bf7cb4
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9bf7cb4 to
8ba9ba2
Compare
8ba9ba2 to
b1e401a
Compare
art049
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.