ci: shard bpf-tests by integration test binary#358
Open
not-matthias wants to merge 1 commit into
Open
Conversation
Each memtrack integration test binary runs its cases serially because the eBPF tracker can't overlap with itself in one process. Sharding at the test-binary level lets the four binaries build and run in parallel across jobs, dropping the critical path from ~13min to ~5min.
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
bpf-testsjob is the long pole of CI at ~13min, while every other job finishes in under 5min. Breakdown of the slow step on a recent run:c_testscpp_testsrust_testsspawn_testsEach memtrack integration test binary runs its cases serially because the eBPF tracker can't safely overlap with itself in one process (
--test-threads 1). That's a per-binary constraint though — different test binaries are fully independent.This shards
bpf-testsinto four matrix jobs, one per integration test binary. Each shard builds only the binary it needs and runs its cases as before. Critical path drops from ~13min to ~5min (longest shard ≈ cpp_tests).Test plan
bpf-tests (...)matrix jobs passcheckjob correctly waits for the whole matrix and turns green