Repository navigation
[client-v2] Convert String to DateTime #3165
Description
Activity
Hey @chernser , I can pick this up and implement
Just wanted a quick check on how flexible we want this "simple logic" to be so I don't build it wrong:
- Epoch Numbers: For a numeric string like "1710000000", should we assume it's always seconds or milliseconds? Or check string length (10 digits vs 13 digits) to guess?
- Formats: For formatted strings, do we want to stick to standard ISO-8601 out of the box, or do you have a specific list of fallback formats we should try parsing against?
Let me know what you prefer here and I'll jump on the PR!
Good day, @shubhamagore !
- we should never guess about data. It creates a lot error in our and application code. Application has better knowledge about it.
- this is the main question. using fallback formats may cause parsing data wrongly (like with dates where month and day are on different positions). We could stick to DB default format But then others will need to convert string to proper format anyway.
Before proceeding we need to learn more usecases - when is it needed, is it a real problem of only few care about it. Because any convenience has cost - we still have to maintain feature and if it become too bulky it will be hard to remove it.
Reacted by Maxim Martynov
Description
Original issue #3132
Define a simple and straightforward logic for converting String to Datetime. Consider next usecases