Skip to content

Use ChatGPTBox naming for Safari builds#1024

Merged
PeterDaveHello merged 1 commit into
masterfrom
unifySafariChatGPTBoxName
Jul 22, 2026
Merged

Use ChatGPTBox naming for Safari builds#1024
PeterDaveHello merged 1 commit into
masterfrom
unifySafariChatGPTBoxName

Conversation

@PeterDaveHello

@PeterDaveHello PeterDaveHello commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary

  • use the canonical ChatGPTBox name for Safari converter, Xcode, application, archive, and DMG output
  • remove the legacy Fission manifest and developer patch scaffolding
  • align README headings with the project name and point Safari badges to the maintained manual installation instructions

Why

The repository and extension manifests use ChatGPTBox, while Safari packaging still used the App Store-specific Fission - ChatBox alias and the README headings used the spaced ChatGPT Box form. This left the same project represented by three different names across documentation, generated Xcode projects, application bundles, and disk images.

The Fission alias was tied to an App Store listing that is no longer available. Keeping it also required a manifest patch that renamed generated Safari input and left an unused developer patch coupled to Fission-specific Xcode paths.

This change restores the canonical ChatGPTBox name throughout the active Safari packaging path, removes the now-redundant patch scaffolding, and directs Safari users to the maintained manual installation instructions. It does not change the bundle identifier, release signing credentials, or publishing behavior. Any future decision to adopt a distinct Safari product name, including trademark considerations, remains separate from this cleanup.

Validation

  • npm run pretty
  • npm run lint
  • npm test (893 tests passed)
  • npm run build
  • Chromium and Firefox manifests retain the ChatGPTBox name
  • Safari converter, Xcode, archive, app, and DMG paths checked for naming consistency
  • shellcheck safari/build.sh
  • bash -n safari/build.sh
  • git diff --check
  • GitHub Actions tests and safari-build passed

Manual browser smoke testing was skipped because no extension runtime files changed.

Remove the obsolete App Store-specific Fission alias and use the
canonical ChatGPTBox name for Safari build artifacts.

Drop the legacy Safari patch scaffolding and replace unavailable App
Store links with the maintained manual installation instructions.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@PeterDaveHello
PeterDaveHello requested a review from Copilot July 21, 2026 21:08
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Safari build and packaging flow now uses ChatGPTBox artifact names, while project metadata and documentation update branding and Safari installation links.

Changes

Safari naming alignment

Layer / File(s) Summary
Safari build and packaging names
safari/build.sh, safari/appdmg.json, safari/project.pre.patch, safari/project_developer.patch, AGENTS.md
Safari conversion, Xcode archive/export paths, DMG metadata, bundle identifiers, signing settings, manifest metadata, and build documentation reflect the updated application naming.
Branding and installation documentation
README*.md
README headings use ChatGPTBox, and Safari installation links point to the project Wiki section.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: Review effort 1/5

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: standardizing Safari build naming to ChatGPTBox.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch unifySafariChatGPTBoxName

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Standardize Safari build artifacts on the ChatGPTBox name

✨ Enhancement 📝 Documentation ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Rename Safari converter/Xcode/DMG outputs from legacy “Fission - ChatBox” to “ChatGPTBox”.
• Remove unused Safari patch scaffolding tied to the old App Store packaging path.
• Update READMEs and badges to reference “ChatGPTBox” and the maintained Safari install guide.
Diagram

graph TD
  A["npm run build"] --> B["Safari converter"] --> C["Xcode archive"] --> D["Export archive"] --> E["appdmg"] --> F["Artifacts: ChatGPTBox.app + safari.dmg"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Centralize product name as a single build constant
  • ➕ Prevents future drift between build.sh, appdmg.json, and docs
  • ➕ Makes renames or multi-brand builds easier (one source of truth)
  • ➖ Adds indirection for a simple naming fix
  • ➖ May require additional scripting/templating to inject into JSON/docs cleanly
2. Keep a compatibility alias for the old “Fission - ChatBox” artifact name
  • ➕ Avoids breaking any external automation expecting the legacy .app path
  • ➖ Continues brand/name inconsistency
  • ➖ Increases maintenance burden (two names to support)

Recommendation: Current approach is appropriate for a one-time canonical rename: directly update the Safari build script and DMG config to emit ChatGPTBox artifacts and remove dead patch scaffolding. If renames are expected again or multiple packaging targets are added, consider centralizing the product name into a single build variable to avoid future inconsistencies.

Files changed (8) +19 / -20

Documentation (6) +13 / -13
AGENTS.mdUpdate Safari build artifact naming in contributor docs +3/-3

Update Safari build artifact naming in contributor docs

• Replaces references to the legacy “Fission - ChatBox.app” with “ChatGPTBox.app”. Clarifies that Safari build uses platform-specific build settings (not patching).

AGENTS.md

README.mdAlign main README name and Safari badge link +2/-2

Align main README name and Safari badge link

• Updates the heading to “ChatGPTBox” and replaces the Safari badge URL from a defunct App Store listing to the wiki manual install instructions.

README.md

README_IN.mdAlign Indonesian README name and Safari badge link +2/-2

Align Indonesian README name and Safari badge link

• Updates the heading to “ChatGPTBox” and points the Safari badge to the maintained wiki install instructions.

README_IN.md

README_JA.mdAlign Japanese README name and Safari badge link +2/-2

Align Japanese README name and Safari badge link

• Updates the heading to “ChatGPTBox” and points the Safari badge to the maintained wiki install instructions.

README_JA.md

README_TR.mdAlign Turkish README name and Safari badge link +2/-2

Align Turkish README name and Safari badge link

• Updates the heading to “ChatGPTBox” and points the Safari badge to the maintained wiki install instructions.

README_TR.md

README_ZH.mdAlign Chinese README name and Safari badge link +2/-2

Align Chinese README name and Safari badge link

• Updates the heading to “ChatGPTBox” and points the Safari badge to the maintained wiki install instructions.

README_ZH.md

Other (2) +6 / -7
appdmg.jsonRename DMG title and bundled app path to ChatGPTBox +2/-2

Rename DMG title and bundled app path to ChatGPTBox

• Changes the DMG window title and the .app file path to use “ChatGPTBox” instead of the legacy alias.

safari/appdmg.json

build.shRename Safari converter and Xcode archive/export paths to ChatGPTBox +4/-5

Rename Safari converter and Xcode archive/export paths to ChatGPTBox

• Removes the pre-conversion patch step and updates converter app-name, Xcode project path, scheme, and archive/export locations to consistently use “ChatGPTBox”.

safari/build.sh

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Safari build/packaging output to use the canonical ChatGPTBox name (matching the extension), removes legacy Safari patch scaffolding tied to the old “Fission - ChatBox” alias, and updates documentation to point Safari users to the maintained manual installation instructions.

Changes:

  • Rename Safari converter/Xcode/archive/app/DMG outputs from “Fission - ChatBox” to “ChatGPTBox”.
  • Remove legacy Safari patch files that were previously applied during packaging.
  • Update README headings and Safari badge links to use “ChatGPTBox” and the wiki install page.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
safari/project.pre.patch Removes legacy manifest-name patch for Safari conversion.
safari/project_developer.patch Removes developer-specific Xcode project patch scaffolding.
safari/build.sh Updates Safari converter and Xcodebuild paths/schemes to the ChatGPTBox naming.
safari/appdmg.json Updates DMG title and bundled app path to ChatGPTBox.app.
README.md Updates project heading and Safari badge URL to the wiki install instructions.
README_ZH.md Same doc updates for Chinese README.
README_TR.md Same doc updates for Turkish README.
README_JA.md Same doc updates for Japanese README.
README_IN.md Same doc updates for Indonesian README.
AGENTS.md Updates Safari artifact naming and build description to match the new packaging flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@PeterDaveHello
PeterDaveHello merged commit b6cd571 into master Jul 22, 2026
5 checks passed
@PeterDaveHello
PeterDaveHello deleted the unifySafariChatGPTBoxName branch July 22, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants