Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Fix pytest setup() deprecation in tests#492

Merged
anilbey merged 5 commits into
BlueBrain:masterfrom
wvangeit:fix_tests
Mar 25, 2024
Merged

Fix pytest setup() deprecation in tests#492
anilbey merged 5 commits into
BlueBrain:masterfrom
wvangeit:fix_tests

Conversation

@wvangeit

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Mar 22, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.05263% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 87.36%. Comparing base (6679d3c) to head (3c34c85).

Files Patch % Lines
bluepyopt/ephys/create_acc.py 79.16% 15 Missing ⚠️
bluepyopt/ephys/simulators.py 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   87.37%   87.36%   -0.01%     
==========================================
  Files          50       50              
  Lines        4347     4346       -1     
==========================================
- Hits         3798     3797       -1     
  Misses        549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wvangeit

Copy link
Copy Markdown
Contributor Author

@AurelienJaquier @anilbey @ilkilic
I fixed the tests that were failing lately, due to changes in pytests. Also made things compatible with python 3.12.

Sorry, for the bid messy PR, but I formatted it with ruff/black too.

Once accepted, can you add python 3.12 as required test in the settings of the repo. Thx.

@anilbey anilbey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @wvangeit

@anilbey anilbey merged commit 43d63a8 into BlueBrain:master Mar 25, 2024
@wvangeit wvangeit deleted the fix_tests branch March 25, 2024 08:55
@anilbey

anilbey commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

and py3.12 became a required action to merge to the master branch ✔️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants