Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

fix exlude examples#467

Merged
anilbey merged 2 commits into
BlueBrain:masterfrom
penguinpee:fix_exlude_examples
Jun 19, 2024
Merged

fix exlude examples#467
anilbey merged 2 commits into
BlueBrain:masterfrom
penguinpee:fix_exlude_examples

Conversation

@penguinpee

@penguinpee penguinpee commented Jul 20, 2023

Copy link
Copy Markdown
Contributor
  • Fix exclusion of examples/

Otherwise examples will be installed as a top level module.
@penguinpee penguinpee force-pushed the fix_exlude_examples branch from 9953a91 to ed2863f Compare July 20, 2023 22:41
@penguinpee

Copy link
Copy Markdown
Contributor Author

See for more information the setuptools docs (the note and important boxes at the end of the linked section).

@anilbey anilbey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anilbey

anilbey commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Thanks @penguinpee for finding out and fixing it.

I confirm with this change the examples are not added to the wheel. The .whl file is slightly smaller in size.

Before

216K ├── bluepyopt-1.14.12-py3-none-any.whl

After

208K ├── bluepyopt-1.14.12.1-py3-none-any.whl

@anilbey anilbey merged commit 4fcf47a into BlueBrain:master Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants